[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp
From: "Commit Hook" <null () kde ! org>
Date: 2012-10-18 14:48:14
Message-ID: 20121018144814.16023.8699 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106636/#review20555
-----------------------------------------------------------
This review has been submitted with commit 014e8f3ca18b0dd22e041f9785afc578f1ebc51b \
by Dawit Alemayehu to branch KDE/4.9.
- Commit Hook
On Oct. 17, 2012, 8:48 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106636/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2012, 8:48 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> The attached patch fixes a regression caused by a commit to fix bug# 88575. Namely, \
> it fixed a problem where filenames with whitespaces in them were not handled \
> correctly by kio_ftp. That is because the filenames were automatically trimmed when \
> read from the directory. However, the fix then re-introduced the original bug and \
> the reason why names were automatically trimmed in the first place. Some ftp \
> servers add bogus whitespace between the date and filename in their listings. \
> Hence, we need need to fix both of these opposing issues without breaking the \
> other. This patch tries to do just that by actually validating each name entry that \
> starts with a whitespace. That way the correct name is sent to the client.
>
> This addresses bug 300988.
> http://bugs.kde.org/show_bug.cgi?id=300988
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.h 2465a4b
> kioslave/ftp/ftp.cpp 26be283
>
> Diff: http://git.reviewboard.kde.org/r/106636/diff/
>
>
> Testing
> -------
>
> - Create 150 folders and 150 text files whose name starts with a whitespace in a \
> directory.
> - Start your preferred ftp server (I tested with vsftpd) on your local machine and \
> login.
> - Make sure you can browse the directory that contains the text files and folders \
> you created above just as quickly as you can other ftp sites.
> - Rename some of the folders and text files by remove the leading whitespace from \
> them and check if that is handled properly.
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106636/">http://git.reviewboard.kde.org/r/106636/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 014e8f3ca18b0dd22e041f9785afc578f1ebc51b by Dawit Alemayehu to \
branch KDE/4.9.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 17th, 2012, 8:48 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2012, 8:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fixes a regression caused by a commit to fix bug# \
88575. Namely, it fixed a problem where filenames with whitespaces in them were not \
handled correctly by kio_ftp. That is because the filenames were automatically \
trimmed when read from the directory. However, the fix then re-introduced the \
original bug and the reason why names were automatically trimmed in the first place. \
Some ftp servers add bogus whitespace between the date and filename in their \
listings. Hence, we need need to fix both of these opposing issues without breaking \
the other. This patch tries to do just that by actually validating each name entry \
that starts with a whitespace. That way the correct name is sent to the client.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Create 150 folders and 150 text files whose name starts with a \
whitespace in a directory.
- Start your preferred ftp server (I tested with vsftpd) on your local machine and \
login.
- Make sure you can browse the directory that contains the text files and folders you \
created above just as quickly as you can other ftp sites.
- Rename some of the folders and text files by remove the leading whitespace from \
them and check if that is handled properly.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=300988">300988</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.h <span style="color: grey">(2465a4b)</span></li>
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(26be283)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106636/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic