--===============2062754667277173096== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/#review20357 ----------------------------------------------------------- cmake/modules/FindSamba.cmake Why the if? If there is no pkgconfig found it the macro will just do no= thing. And pkgconfig could even work on Windows if it is properly installed. cmake/modules/FindSamba.cmake trailing whitespace cmake/modules/FindSamba.cmake That should be HINTS: = From cmake help: = Search the paths specified by the HINTS option. These should be paths c= omputed by system introspection, such as a hint provided by the location of= another item already found. Hard-coded guesses should be specified with th= e PATHS option. cmake/modules/FindSamba.cmake trailing whitespace cmake/modules/FindSamba.cmake HINTS - Rolf Eike Beer On Oct. 14, 2012, 11:43 p.m., Rex Dieter wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106861/ > ----------------------------------------------------------- > = > (Updated Oct. 14, 2012, 11:43 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-sta= ndard-ish locations. > = > = > Diffs > ----- > = > cmake/modules/FindSamba.cmake 16522c6 = > = > Diff: http://git.reviewboard.kde.org/r/106861/diff/ > = > = > Testing > ------- > = > Tested on fedora 18 against samba-4.0-rc2 > = > = > Thanks, > = > Rex Dieter > = > --===============2062754667277173096== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106861/

= =
cmake/modules/FindSamba.cmake (Diff revision 1) 


  

 

  

    20
    
find_path(SAMBA_INCLUDE_DIR NAMES libsmbclient.h )

    20
    
IF (NOT WIN32)

  


 





Why the if? If there is no pkgconfig found it the macro will just do=
 nothing. And pkgconfig could even work on Windows if it is properly instal=
led.

















 =

 =




 

 
  

   
    cmake/modules/FindSamba.cmake
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    27
    
find_path(SAMBA_INCLUDE_DIR NAMES libsmbclient.h 

  


 





trailing whitespace

















 =

 =




 

 
  

   
    cmake/modules/FindSamba.cmake
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    28
    
          PATHS
=

  


 





That should be HINTS:

From cmake help:

Search the paths specified by the HINTS option. These should be paths compu=
ted by system introspection, such as a hint provided by the location of ano=
ther item already found. Hard-coded guesses should be specified with the PA=
THS option.

















 =

 =




 

 
  

   
    cmake/modules/FindSamba.cmake
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    32
    
find_library(SAMBA_LIBRARIES NAMES smbclient 

  


 





trailing whitespace

















 =

 =




 

 
  

   
    cmake/modules/FindSamba.cmake
    

     (Diff revision 1)

    
   
  

 

 
  


   


  

 

  

    
    

    33
    
             PATHS

  


 





HINTS









- Rolf Eike






On October 14th, 2012, 11:43 p.m., Rex Dieter wrote:









 

  


Review request for kdelibs.


By Rex Dieter.




Updated Oct. 14, 2012, 11:43 p.m.








Descripti=
on 

 

 

  
   
Add pkgconfig hints to FindSamba.cmake, helps find samba4 li=
bs on non-standard-ish locations.

  		
 






Testing <=
/h1>


 

  
   
Tested on fedora 18 against samba-4.0-rc2

  		
 








Diffs=
 


    

 
  • cmake/modules/FindSamba.cmake (16522c6)
    • 





View Diff





  		
 











  

 



--===============2062754667277173096==--