This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/

cmake/modules/FindSamba.cmake (Diff revision 1)

20	find_path(SAMBA_INCLUDE_DIR NAMES libsmbclient.h )	20	IF (NOT WIN32)

Why the if? If there is no pkgconfig found it the macro will just do nothing. And pkgconfig could even work on Windows if it is properly installed.

cmake/modules/FindSamba.cmake (Diff revision 1)

		27	find_path(SAMBA_INCLUDE_DIR NAMES libsmbclient.h

trailing whitespace

cmake/modules/FindSamba.cmake (Diff revision 1)

		28	PATHS

That should be HINTS:

From cmake help:

Search the paths specified by the HINTS option. These should be paths computed by system introspection, such as a hint provided by the location of another item already found. Hard-coded guesses should be specified with the PATHS option.

cmake/modules/FindSamba.cmake (Diff revision 1)

		32	find_library(SAMBA_LIBRARIES NAMES smbclient

trailing whitespace

cmake/modules/FindSamba.cmake (Diff revision 1)

		33	PATHS

HINTS

- Rolf Eike

On October 14th, 2012, 11:43 p.m., Rex Dieter wrote:

Review request for kdelibs.

By Rex Dieter.

Updated Oct. 14, 2012, 11:43 p.m.

Description

Add pkgconfig hints to FindSamba.cmake, helps find samba4 libs on non-standard-ish locations.

Testing

Tested on fedora 18 against samba-4.0-rc2

Diffs

cmake/modules/FindSamba.cmake (16522c6)

View Diff