[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to res
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2012-10-12 2:57:20
Message-ID: 20121012025720.32747.54488 () vidsolbach ! de
[Download RAW message or body]
> On Oct. 12, 2012, 2:11 a.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > a78c6a50dcb33028eb572bc260bdaca8f30a597a by Dawit Alemayehu to branch KDE/4.9.
Ahhh... I did not do this! How did this patch end up being cherry-picked into 4.9 \
branch ??!?! It is only supposed to be in master for 4.10 release.
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review20214
-----------------------------------------------------------
On Oct. 8, 2012, 5:43 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2012, 5:43 p.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Description
> -------
>
> The attached patch fixes one of those pet peeve bugs that infurate me from time to \
> time by allowing me to unselect the sessions I do not want to be restored when \
> Konqueror's restore session dialog pops up.
>
> This addresses bug 260282.
> http://bugs.kde.org/show_bug.cgi?id=260282
>
>
> Diffs
> -----
>
> konqueror/src/konqsessionmanager.h ee629e4
> konqueror/src/konqsessionmanager.cpp 68a003f
>
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
>
>
> Testing
> -------
>
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain \
> the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
>
>
> Screenshots
> -----------
>
> new restore dialog
> http://git.reviewboard.kde.org/r/106503/s/760/
> old restore dialog
> http://git.reviewboard.kde.org/r/106503/s/759/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106503/">http://git.reviewboard.kde.org/r/106503/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 12th, 2012, 2:11 a.m., <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
a78c6a50dcb33028eb572bc260bdaca8f30a597a by Dawit Alemayehu to branch KDE/4.9.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ahhh... I did not do \
this! How did this patch end up being cherry-picked into 4.9 branch ??!?! It is only \
supposed to be in master for 4.10 release.</pre> <br />
<p>- Dawit</p>
<br />
<p>On October 8th, 2012, 5:43 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2012, 5:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fixes one of those pet peeve bugs that infurate me \
from time to time by allowing me to unselect the sessions I do not want to be \
restored when Konqueror's restore session dialog pops up.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Unselected sessions should not be restored.
* If all available sessions are selected (the default), the behavior should remain \
the same as it is today.
* If all available sessions are unselected, disable the "Restore Session" \
button.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260282">260282</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqsessionmanager.h <span style="color: \
grey">(ee629e4)</span></li>
<li>konqueror/src/konqsessionmanager.cpp <span style="color: \
grey">(68a003f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106503/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106503/s/760/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/new_konqueror_restore_dialog_400x100.png" \
style="border: 1px black solid;" alt="new restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/759/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/08/old_konqueror_restore_dialog_400x100.png" \
style="border: 1px black solid;" alt="old restore dialog" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic