[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: miscelaneous things
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-10-10 13:40:42
Message-ID: 20121010134042.31335.84759 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106782/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
1. change order between setting parent d-> property and deleting this d->. =
(Probably does nothing)
2. Assign directly this to o pointer
3. Avoid the use of a possible null pointer (it is checked before) propAnim
Diffs
-----
plasma/containment.cpp 5f13c2b =
plasma/datacontainer.cpp fd1ad89 =
plasma/private/applethandle.cpp f6d51a2 =
Diff: http://git.reviewboard.kde.org/r/106782/diff/
Testing
-------
This has helped me to know more about bug 297684
(that I still suffer :-( )
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106782/">http://git.reviewboard.kde.org/r/106782/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. change order between setting parent d-> property and deleting this \
d->. (Probably does nothing) 2. Assign directly this to o pointer
3. Avoid the use of a possible null pointer (it is checked before) propAnim</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This has helped me to know more about bug 297684 (that I still suffer \
:-( )</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/containment.cpp <span style="color: grey">(5f13c2b)</span></li>
<li>plasma/datacontainer.cpp <span style="color: grey">(fd1ad89)</span></li>
<li>plasma/private/applethandle.cpp <span style="color: grey">(f6d51a2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106782/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic