[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default
From:       Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date:       2012-10-09 4:35:25
Message-ID: 1569319.ys9VrdSQz6 () martin-desktop
[Download RAW message or body]


On Monday 08 October 2012 22:40:55 Albert Astals Cid wrote:
> Hi fellow kde-core-develers, i was thinking that from time to time someone
> commits some code that breaks the building of the tests.
> 
> This happens because people is not aware that those parts are unit tested.
> 
> I think that by enabling the building of the tests by default we at least
> make sure the tests will build and maybe when people see their code
> actually breaking the compilation of a unit test we get them to run them
> and maybe even improve them :-)
> 
> Of course, enabling building the tests by defaults makes compilation times a
> bit longer,
Given the huge number of unit tests we have, I hardly doubt that this would 
matter at all.

Let's try to get it into a state that it matters, so +1

Cheers
Martin

> but I do think that the benefits far surpass the problems and
> for people with really slow machines and/or needs to recompile stuff a lot
> there is always the possibility that they can ask cmake not to build the
> tests.
> 
> Comments?
> 
> Cheers,
>   Albert

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]