[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to res
From: "David Faure" <faure () kde ! org>
Date: 2012-10-08 10:30:21
Message-ID: 20121008103021.18907.44127 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106503/#review20065
-----------------------------------------------------------
konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15891>
Did you change this if() wrongly?
Now the code says "if I could find the dialog-warning icon, then ignore it and \
ask QStyle instead".
This makes no sense ;)
konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15890>
All this generic code could be simplified for the use case at hand. Maybe after \
inserting a '\n' in the string (between the two sentences), and then all that \
squeezing and wrapping can be removed. Let's keep this simple and maintainable.
konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15889>
This line and the one below, can be removed now. They don't do anything.
konqueror/src/konqsessionmanager.cpp
<http://git.reviewboard.kde.org/r/106503/#comment15892>
The label is two lines at most, it will never be bigger than a third of the \
desktop height. Remove usingScrollArea and the associated code.
The tree widget can be tall, yes, but not the label on top.
- David Faure
On Oct. 4, 2012, 3:50 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106503/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2012, 3:50 a.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Description
> -------
>
> The attached patch fixes one of those pet peeve bugs that infurate me from time to \
> time by allowing me to unselect the sessions I do not want to be restored when \
> Konqueror's restore session dialog pops up.
>
> This addresses bug 260282.
> http://bugs.kde.org/show_bug.cgi?id=260282
>
>
> Diffs
> -----
>
> konqueror/src/konqsessionmanager.h ee629e4
> konqueror/src/konqsessionmanager.cpp 68a003f
>
> Diff: http://git.reviewboard.kde.org/r/106503/diff/
>
>
> Testing
> -------
>
> * Unselected sessions should not be restored.
> * If all available sessions are selected (the default), the behavior should remain \
> the same as it is today.
> * If all available sessions are unselected, disable the "Restore Session" button.
>
>
> Screenshots
> -----------
>
> old restore dialog
> http://git.reviewboard.kde.org/r/106503/s/729/
> new restore dialog
> http://git.reviewboard.kde.org/r/106503/s/731/
> new restore dialog v2
> http://git.reviewboard.kde.org/r/106503/s/739/
> new restore dialog v3
> http://git.reviewboard.kde.org/r/106503/s/750/
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106503/">http://git.reviewboard.kde.org/r/106503/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106503/diff/6/?file=88345#file88345line123" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/src/konqsessionmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">SessionRestoreDialog::SessionRestoreDialog(const QStringList& \
sessionFilePaths, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">123</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">icon</span><span class="p">.</span><span class="n">isNull</span><span \
class="p">())</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did you \
change this if() wrongly?
Now the code says "if I could find the dialog-warning icon, then ignore it and \
ask QStyle instead".
This makes no sense ;)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106503/diff/6/?file=88345#file88345line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/src/konqsessionmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">SessionRestoreDialog::SessionRestoreDialog(const QStringList& \
sessionFilePaths, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">145</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// enable automatic wrapping of messages which are longer than 50% of \
screen width</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All this \
generic code could be simplified for the use case at hand. Maybe after inserting a \
'\n' in the string (between the two sentences), and then all that squeezing \
and wrapping can be removed. Let's keep this simple and maintainable.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106503/diff/6/?file=88345#file88345line156" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/src/konqsessionmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">SessionRestoreDialog::SessionRestoreDialog(const QStringList& \
sessionFilePaths, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">156</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPalette</span> <span class="n">messagePal</span><span \
class="p">(</span><span class="n">messageLabel</span><span \
class="o">-></span><span class="n">palette</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This line \
and the one below, can be removed now. They don't do anything.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106503/diff/6/?file=88345#file88345line159" \
style="color: black; font-weight: bold; text-decoration: \
underline;">konqueror/src/konqsessionmanager.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">SessionRestoreDialog::SessionRestoreDialog(const QStringList& \
sessionFilePaths, QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">159</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">const</span> <span class="kt">bool</span> <span \
class="n">usingScrollArea</span> <span class="o">=</span> <span \
class="n">desktop</span><span class="p">.</span><span class="n">height</span><span \
class="p">()</span> <span class="o">/</span> <span class="mi">3</span> <span \
class="o"><</span> <span class="n">messageLabel</span><span \
class="o">-></span><span class="n">sizeHint</span><span class="p">().</span><span \
class="n">height</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The label \
is two lines at most, it will never be bigger than a third of the desktop height. \
Remove usingScrollArea and the associated code.
The tree widget can be tall, yes, but not the label on top.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On October 4th, 2012, 3:50 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated Oct. 4, 2012, 3:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch fixes one of those pet peeve bugs that infurate me \
from time to time by allowing me to unselect the sessions I do not want to be \
restored when Konqueror's restore session dialog pops up.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Unselected sessions should not be restored.
* If all available sessions are selected (the default), the behavior should remain \
the same as it is today.
* If all available sessions are unselected, disable the "Restore Session" \
button.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260282">260282</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqsessionmanager.h <span style="color: \
grey">(ee629e4)</span></li>
<li>konqueror/src/konqsessionmanager.cpp <span style="color: \
grey">(68a003f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106503/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106503/s/729/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/old_konqueror_restore_dialog_400x100.png" \
style="border: 1px black solid;" alt="old restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/731/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/19/new_konqueror_restore_dialog_1_400x100.png" \
style="border: 1px black solid;" alt="new restore dialog" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/739/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/28/new_konqueror_restore_dialog_1_400x100.png" \
style="border: 1px black solid;" alt="new restore dialog v2" /></a>
<a href="http://git.reviewboard.kde.org/r/106503/s/750/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/01/new_konqueror_restore_dialog_400x100.png" \
style="border: 1px black solid;" alt="new restore dialog v3" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic