This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106755/

I do not w=
ant the notifier to show this information in the device view; indeed, for d=
evices with a label, the mount point is /media/<label>, so the inform=
ation about the mount point would look like quite redundant.
Perhaps you could show it in a tooltip, instead; that would be acceptable i=
mho

In any case, the =E2=80=9Ctrouble with unmounting=E2=80=9D usecase should b=
e resolved in some other way (e.g. by making use of lsof in solid to identi=
fy blocking apps), so I am not super-sure that the user should be given suc=
h specific information as /dev/xxxx. =

- Jacopo De

On October 7th, 2012, 2:55 p.m., Jonathan Marten wrote:

Review request for KDE Base Apps and Plasma.

By Jonathan Marten.

Updated Oct. 7, 2012, 2:55 p.m.

Descripti= on

If a removable device is mounted using the Plasma device not=
ifier, there is no indication of what the Unix name of the device is or whe=
re it is mounted.  This information may be useful to the user for (a) acces=
sing the mounted device from non-KDE applications, or (b) troubleshooting m=
ounting or unmounting problems.

The attached patch shows this information when the device is hovered over, =
just above the "N actions for this device" text.  Depending on wh=
ether or not the device is mounted, there are three possibilities that can =
be shown here:

  /dev/XXX                           when not mounted
  /dev/XXX mounted on /media/YYYY    when mounted
  /dev/XXX mounted                   if mounted but the mount point is not =
available

Please be gentle, this is my first QML patch :-)

Testing <= /h1>

Built kde-workspace with this change, observed operation and=
 display of device notifier with a selection of removable devices.

Bugs: 196939

Diffs=

plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.q= ml (2a9b3f7)

View Diff

Screensho= ts

Descripti= on

Testing <= /h1> Built kde-workspace with this change, observed operation and= display of device notifier with a selection of removable devices. Bugs: 196939

Diffs=

Screensho= ts

Testing <= /h1>

Built kde-workspace with this change, observed operation and= display of device notifier with a selection of removable devices.

Bugs: 196939