From kde-core-devel Sun Oct 07 15:32:26 2012 From: "Jacopo De Simoi" Date: Sun, 07 Oct 2012 15:32:26 +0000 To: kde-core-devel Subject: Re: Review Request: Device notifier: show mounted device and path Message-Id: <20121007153226.32303.67679 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134962397601979 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3749226835857818117==" --===============3749226835857818117== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106755/#review20039 ----------------------------------------------------------- I do not want the notifier to show this information in the device view; ind= eed, for devices with a label, the mount point is /media/, so the in= formation about the mount point would look like quite redundant. Perhaps you could show it in a tooltip, instead; that would be acceptable i= mho In any case, the =E2=80=9Ctrouble with unmounting=E2=80=9D usecase should b= e resolved in some other way (e.g. by making use of lsof in solid to identi= fy blocking apps), so I am not super-sure that the user should be given suc= h specific information as /dev/xxxx. = = - Jacopo De Simoi On Oct. 7, 2012, 2:55 p.m., Jonathan Marten wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106755/ > ----------------------------------------------------------- > = > (Updated Oct. 7, 2012, 2:55 p.m.) > = > = > Review request for KDE Base Apps and Plasma. > = > = > Description > ------- > = > If a removable device is mounted using the Plasma device notifier, there = is no indication of what the Unix name of the device is or where it is moun= ted. This information may be useful to the user for (a) accessing the moun= ted device from non-KDE applications, or (b) troubleshooting mounting or un= mounting problems. > = > The attached patch shows this information when the device is hovered over= , just above the "N actions for this device" text. Depending on whether or= not the device is mounted, there are three possibilities that can be shown= here: > = > /dev/XXX when not mounted > /dev/XXX mounted on /media/YYYY when mounted > /dev/XXX mounted if mounted but the mount point is no= t available > = > Please be gentle, this is my first QML patch :-) > = > = > This addresses bug 196939. > http://bugs.kde.org/show_bug.cgi?id=3D196939 > = > = > Diffs > ----- > = > plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qm= l 2a9b3f7 = > = > Diff: http://git.reviewboard.kde.org/r/106755/diff/ > = > = > Testing > ------- > = > Built kde-workspace with this change, observed operation and display of d= evice notifier with a selection of removable devices. > = > = > Screenshots > ----------- > = > Device notifier with mounted device > http://git.reviewboard.kde.org/r/106755/s/756/ > = > = > Thanks, > = > Jonathan Marten > = > --===============3749226835857818117== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106755/

I do not w=
ant the notifier to show this information in the device view; indeed, for d=
evices with a label, the mount point is /media/<label>, so the inform=
ation about the mount point would look like quite redundant.
Perhaps you could show it in a tooltip, instead; that would be acceptable i=
mho

In any case, the =E2=80=9Ctrouble with unmounting=E2=80=9D usecase should b=
e resolved in some other way (e.g. by making use of lsof in solid to identi=
fy blocking apps), so I am not super-sure that the user should be given suc=
h specific information as /dev/xxxx. =

- Jacopo De

On October 7th, 2012, 2:55 p.m., Jonathan Marten wrote:

Review request for KDE Base Apps and Plasma.

By Jonathan Marten.

Updated Oct. 7, 2012, 2:55 p.m.

Descripti= on

If a removable device is mounted using the Plasma device not=
ifier, there is no indication of what the Unix name of the device is or whe=
re it is mounted.  This information may be useful to the user for (a) acces=
sing the mounted device from non-KDE applications, or (b) troubleshooting m=
ounting or unmounting problems.

The attached patch shows this information when the device is hovered over, =
just above the "N actions for this device" text.  Depending on wh=
ether or not the device is mounted, there are three possibilities that can =
be shown here:

  /dev/XXX                           when not mounted
  /dev/XXX mounted on /media/YYYY    when mounted
  /dev/XXX mounted                   if mounted but the mount point is not =
available

Please be gentle, this is my first QML patch :-)

Testing <= /h1>

Built kde-workspace with this change, observed operation and=
 display of device notifier with a selection of removable devices.

Bugs: 196939

Diffs=

plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.q= ml (2a9b3f7)

Screensho= ts

3D"Device

--===============3749226835857818117==--