--===============0645707797514677699== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106475/#review19914 ----------------------------------------------------------- Causes a regression. When using "Save Image As..." in Konqueror, the file d= ialog starts at "Custom Path" (and lists root folder), without remembering = the previously used path. - Christoph Feck On Sept. 17, 2012, 10:39 a.m., Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106475/ > ----------------------------------------------------------- > = > (Updated Sept. 17, 2012, 10:39 a.m.) > = > = > Review request for kdelibs and David Faure. > = > = > Description > ------- > = > This patch addresses the following bug: > When an user clicks in a KUrlRequestUrl("smb://") to open the dialog, the= KFIleDialog will be opened with the "current working dir" instead of smb:// > = > Debugging the issue, I reached KFileWidget::getStartUrl, in that method t= here is a check that looks if the directory is not empty, in case it is the= directory (startDir) is discarded in favor of some magic code that looks f= or recent folders blablabla. > = > this code apparently was added to support the case where an url is compos= ed only by a fileName, for example when Konqueror Save as (commit 4d3933d4)= . So the solution I thought is to check if the schema is not empty, in case= both directory and schema are empty the KUrl will be discarded as well, in= stead if any of them is not empty the directory will be used. > = > = > Diffs > ----- > = > kfile/kfilewidget.cpp 7069a49 = > = > Diff: http://git.reviewboard.kde.org/r/106475/diff/ > = > = > Testing > ------- > = > Used Konqueror (as indicated in the commit) with both khtml and webkit. > Tested samba-mounter > Tested bluedevil > = > Everything seems to work. > = > = > Thanks, > = > Alex Fiestas > = > --===============0645707797514677699== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106475/ 

Causes a r=
egression. When using "Save Image As..." in Konqueror, the file d=
ialog starts at "Custom Path" (and lists root folder), without re=
membering the previously used path.

- Christoph


On September 17th, 2012, 10:39 a.m., Alex Fiestas wrote:

Review request for kdelibs and David Faure.
By Alex Fiestas.

Updated Sept. 17, 2012, 10:39 a.m.

Descripti= on 

This patch addresses the following bug:
When an user clicks in a KUrlRequestUrl("smb://") to open the dia=
log, the KFIleDialog will be opened with the "current working dir"=
; instead of smb://

Debugging the issue, I reached KFileWidget::getStartUrl, in that method the=
re is a check that looks if the directory is not empty, in case it is the d=
irectory (startDir) is discarded in favor of some magic code that looks for=
 recent folders blablabla.

this code apparently was added to support the case where an url is composed=
 only by a fileName, for example when Konqueror Save as (commit 4d3933d4). =
So the solution I thought is to check if the schema is not empty, in case b=
oth directory and schema are empty the KUrl will be discarded as well, inst=
ead if any of them is not empty the directory will be used.

Testing <= /h1> 
Used Konqueror (as indicated in the commit) with both khtml =
and webkit.
Tested samba-mounter
Tested bluedevil

Everything seems to work.

Diffs=

  • kfile/kfilewidget.cpp (7069a49)

View Diff
--===============0645707797514677699==--