[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Use product as text for pluggable/removable devices
From: "Alex Fiestas" <alex () eyeos ! org>
Date: 2012-10-02 19:29:43
Message-ID: 20121002192943.25444.77146 () vidsolbach ! de
[Download RAW message or body]
> On Sept. 30, 2012, 12:23 a.m., Alex Fiestas wrote:
> > I decided to make a review because I wonder why we were using descripti=
on before, was it working better with HAL?
> =
> Kevin Ottens wrote:
> Nope, but the HAL backend itself used to have a very similar piece of=
code. It's probably a better idea to have that code in the udisk* backends=
than in KFilePlacesModel.
I totally agree that doing this in the udisk backend is way cleaner than pa=
tching all 3 things (KFilePlacesModel, PlacesItemModel and notifier).
I will add (if it is not already there) some info in the documentation and =
review a patch doing this in udisk backend.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106653/#review19613
-----------------------------------------------------------
On Sept. 30, 2012, 12:22 a.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106653/
> -----------------------------------------------------------
> =
> (Updated Sept. 30, 2012, 12:22 a.m.)
> =
> =
> Review request for kdelibs and Kevin Ottens.
> =
> =
> Description
> -------
> =
> The description is useful for when the device is not hotpluggable/removea=
ble, for example to show:
> 96.3 GiB Hard Drive
> 15.1 GiB Hard Drive
> =
> instead of two identical labels.
> =
> But when it comes to removable/hotpluggable we want to show the Product t=
o be able to show:
> =
> Nokia N9
> Nexus 7
> =
> Instead of =
> Portable Media Player
> Portable Media Player
> =
> Screenshots from this review are applicable:
> https://git.reviewboard.kde.org/r/106637/
> =
> =
> Diffs
> -----
> =
> kfile/kfileplacesitem.cpp 3ada0c3 =
> =
> Diff: http://git.reviewboard.kde.org/r/106653/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Alex Fiestas
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106653/">http://git.reviewboard.kde.org/r/106653/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 30th, 2012, 12:23 a.m., <b>Alex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I decided to make a review because I wonder why we were using \
description before, was it working better with HAL?</pre> </blockquote>
<p>On October 1st, 2012, 5:34 a.m., <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, but the HAL \
backend itself used to have a very similar piece of code. It's probably a better \
idea to have that code in the udisk* backends than in KFilePlacesModel.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I totally agree that \
doing this in the udisk backend is way cleaner than patching all 3 things \
(KFilePlacesModel, PlacesItemModel and notifier).
I will add (if it is not already there) some info in the documentation and review a \
patch doing this in udisk backend.</pre> <br />
<p>- Alex</p>
<br />
<p>On September 30th, 2012, 12:22 a.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Kevin Ottens.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2012, 12:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The description is useful for when the device is not \
hotpluggable/removeable, for example to show: 96.3 GiB Hard Drive
15.1 GiB Hard Drive
instead of two identical labels.
But when it comes to removable/hotpluggable we want to show the Product to be able to \
show:
Nokia N9
Nexus 7
Instead of
Portable Media Player
Portable Media Player
Screenshots from this review are applicable:
https://git.reviewboard.kde.org/r/106637/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kfileplacesitem.cpp <span style="color: grey">(3ada0c3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106653/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic