[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2012-10-01 15:26:54
Message-ID: 20121001152654.6631.7062 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106671/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
that adds all html functionality to the javascript Audio.
Previous one just had pause/play/stop/omload/onerror and
NOTE "stop" is not even part of the HTMLAudioElement/HTMLMediaElement(.idl), so its removed now.
Diffs
-----
khtml/CMakeLists.txt 99034cc
khtml/ecma/kjs_audio.h 956d72a
khtml/ecma/kjs_audio.cpp f67cdc9
Diff: http://git.reviewboard.kde.org/r/106671/diff/
Testing
-------
Makes websites like
http://release.blackmesasource.com/?sm2-preferflash=false
and
http://9elements.com/html5demos/audio/
from the javascript point of view
not 100% as the html element is still missing some implementations
e.g. scheduleLoad and canplay event
Thanks,
Bernd Buschinski
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106671/">http://git.reviewboard.kde.org/r/106671/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it
that adds all html functionality to the javascript Audio.
Previous one just had pause/play/stop/omload/onerror and
NOTE "stop" is not even part of the \
HTMLAudioElement/HTMLMediaElement(.idl), so its removed now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Makes websites like \
http://release.blackmesasource.com/?sm2-preferflash=false and
http://9elements.com/html5demos/audio/
from the javascript point of view
not 100% as the html element is still missing some implementations
e.g. scheduleLoad and canplay event</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khtml/CMakeLists.txt <span style="color: grey">(99034cc)</span></li>
<li>khtml/ecma/kjs_audio.h <span style="color: grey">(956d72a)</span></li>
<li>khtml/ecma/kjs_audio.cpp <span style="color: grey">(f67cdc9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106671/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic