--===============2559357444273656386== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review19620 ----------------------------------------------------------- Looks good to me (feel free to commit if nobody else has comments). But then, what if someone is annoyed by icon views, and wants a details vie= w everywhere? [switch this sentence around if the default is details view] He'll have to switch the view mode of kfiledialog in every single KDE app, = right? Tough problem, there's never a perfect solution with these things (making e= veryone happy leads to too many config options, and alternatives leave some= people unhappy). - David Faure On Sept. 26, 2012, 4:19 p.m., Aur=C3=A9lien G=C3=A2teau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106581/ > ----------------------------------------------------------- > = > (Updated Sept. 26, 2012, 4:19 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > This patch makes KFileDialog remember settings such as which view mode is= selected and whether the places sidebar should be visible. > = > Original code tried to save those to kdeglobals so that changes would be = shared among all applications but it did so the wrong way. The patch writes= the configuration to kdeglobals correctly, but saves the KDirOperator to t= he application config file (KDirOperator configuration settings are sort se= ttings, show preview, show hidden files, view style (icon, detail, treeview= )) > = > There are two reasons for not saving KDirOperator config to kdeglobals: > = > 1. It is right now not possible to tell KDirOperator::writeConfig() to sa= ve to kdeglobals. It could be done by adding a new version of writeConfig()= which would accept a KConfigBase::WriteFlags argument though. > = > 2. It probably would not be a good idea to remember KDirOperator settings= globally anyway because depending on the application one may want to use d= ifferent settings. > For example if user wants to select images or videos he might set the fil= e dialog to show big icons and the preview pane (so that videos can be play= ed). This setup would however not be adapted in an application where one wa= nts to select a text file. > = > = > This addresses bug 139475. > http://bugs.kde.org/show_bug.cgi?id=3D139475 > = > = > Diffs > ----- > = > kfile/kfilewidget.cpp 8e2f967 = > = > Diff: http://git.reviewboard.kde.org/r/106581/diff/ > = > = > Testing > ------- > = > Tested with two different KDE applications. Settings are correctly rememb= ered. > = > = > Thanks, > = > Aur=C3=A9lien G=C3=A2teau > = > --===============2559357444273656386== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106581/ 

Looks good=
 to me (feel free to commit if nobody else has comments).

But then, what if someone is annoyed by icon views, and wants a details vie=
w everywhere? [switch this sentence around if the default is details view]
He'll have to switch the view mode of kfiledialog in every single KDE a=
pp, right?
Tough problem, there's never a perfect solution with these things (maki=
ng everyone happy leads to too many config options, and alternatives leave =
some people unhappy).

- David


On September 26th, 2012, 4:19 p.m., Aur=C3=A9lien G=C3=A2teau wrote:

Review request for kdelibs.
By Aur=C3=A9lien G=C3=A2teau.

Updated Sept. 26, 2012, 4:19 p.m.

Descripti= on 

This patch makes KFileDialog remember settings such as which=
 view mode is selected and whether the places sidebar should be visible.

Original code tried to save those to kdeglobals so that changes would be sh=
ared among all applications but it did so the wrong way. The patch writes t=
he configuration to kdeglobals correctly, but saves the KDirOperator to the=
 application config file (KDirOperator configuration settings are sort sett=
ings, show preview, show hidden files, view style (icon, detail, treeview))

There are two reasons for not saving KDirOperator config to kdeglobals:

1. It is right now not possible to tell KDirOperator::writeConfig() to save=
 to kdeglobals. It could be done by adding a new version of writeConfig() w=
hich would accept a KConfigBase::WriteFlags argument though.

2. It probably would not be a good idea to remember KDirOperator settings g=
lobally anyway because depending on the application one may want to use dif=
ferent settings.
For example if user wants to select images or videos he might set the file =
dialog to show big icons and the preview pane (so that videos can be played=
). This setup would however not be adapted in an application where one want=
s to select a text file.

Testing <= /h1> 
Tested with two different KDE applications. Settings are cor=
rectly remembered.
Bugs: 139475

Diffs=

  • kfile/kfilewidget.cpp (8e2f967)

View Diff
--===============2559357444273656386==--