[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Ability to select which screen savers are used for "Random"
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2012-09-22 9:28:35
Message-ID: 20120922092835.31011.78388 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106524/#review19288
-----------------------------------------------------------
this UI is completely opaque to the user and thus not acceptable.
you have two options:
- add a proper header to the tree and put the checkboxes into a separate column \
"allow in 'random'". the list's double function is still confusing, \
though.
- put it into a separate config dialog after all. with some minor refactoring there \
shouldn't be much code duplication. i'd prefer this approach.
i'm pretty sure this patch will massively conflict with \
http://git.reviewboard.kde.org/r/106124/
please use kdelibs (or even better qt, as far as i'm concerned) coding style for new \
code. at the very least stay consistent with yourself.
kcontrol/screensaver/scrnsave.cpp
<http://git.reviewboard.kde.org/r/106524/#comment15270>
endsWith
kcontrol/screensaver/scrnsave.cpp
<http://git.reviewboard.kde.org/r/106524/#comment15271>
unrelated style change. don't do that.
- Oswald Buddenhagen
On Sept. 21, 2012, 12:57 p.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106524/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2012, 12:57 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Description
> -------
>
> The referenced bug suggests that it should be possible to individually select \
> screen savers that are to be considered when the "Random" option is chosen. This \
> patch implements that.
> In order to avoid having to duplicate the complete saver tree view (and the code to \
> generate it) within the random saver's setup mode, check boxes are added to the \
> kcontrol saver list (with the exception of the random saver itself). The state of \
> these is saved to the random saver's config file. This selection is in addition to \
> the two options within the saver's setup dialogue, so if for example "Use OpenGL \
> screen savers" is not checked than any OpenGL savers will be ignored even if their \
> boxes are checked in the tree view.
> (Submitting to kde-runtime, there is no kde-workspace group)
>
>
> This addresses bug 57572.
> http://bugs.kde.org/show_bug.cgi?id=57572
>
>
> Diffs
> -----
>
> kcontrol/screensaver/scrnsave.h 7c8deba
> kcontrol/screensaver/scrnsave.cpp c0507d4
> kscreensaver/krandom_screensaver/random.cpp 4047184
>
> Diff: http://git.reviewboard.kde.org/r/106524/diff/
>
>
> Testing
> -------
>
> Built saver and kcontrol module with these changes. Checked operation of kcontrol \
> module, saving of settings in the config file and operation of the random saver.
>
> Screenshots
> -----------
>
> kcmshell4 screensaver
> http://git.reviewboard.kde.org/r/106524/s/733/
>
>
> Thanks,
>
> Jonathan Marten
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106524/">http://git.reviewboard.kde.org/r/106524/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this UI is completely \
opaque to the user and thus not acceptable. you have two options:
- add a proper header to the tree and put the checkboxes into a separate column \
"allow in 'random'". the list's double function is still \
confusing, though.
- put it into a separate config dialog after all. with some minor refactoring there \
shouldn't be much code duplication. i'd prefer this approach.
i'm pretty sure this patch will massively conflict with \
http://git.reviewboard.kde.org/r/106124/
please use kdelibs (or even better qt, as far as i'm concerned) coding style for \
new code. at the very least stay consistent with yourself.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106524/diff/1/?file=86657#file86657line450" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/screensaver/scrnsave.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KScreenSaver::findSavers()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">450</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">item</span><span class="o">-></span><span class="n">setIcon</span><span \
class="p">(</span><span class="mi">0</span><span class="p">,</span> <span \
class="n">KIcon</span><span class="p">(</span><span class="n">s</span><span \
class="o">-></span><span class="n">exec</span><span class="p">().</span><span \
class="n">contains</span><span class="p">(</span><span \
class="s">".kss"</span><span class="p">)</span> <span class="o">?</span> \
<span class="s">"kde"</span> <span class="o">:</span> <span \
class="s">"xorg"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">endsWith</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106524/diff/1/?file=86657#file86657line705" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/screensaver/scrnsave.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KScreenSaver::slotSetup()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">623</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">kxsconfig</span> <span class="o">=</span> \
<span class="n">word</span> <span class="o">==</span> <span \
class="s">"kxsconfig"</span><span class="p">;</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">705</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">bool</span> <span class="n">kxsconfig</span> <span class="o">=</span> \
<span class="p"><span class="hl">(</span></span><span class="n">word</span> <span \
class="o">==</span> <span class="s">"kxsconfig"</span><span class="p"><span \
class="hl">)</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unrelated \
style change. don't do that.</pre> </div>
<br />
<p>- Oswald</p>
<br />
<p>On September 21st, 2012, 12:57 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2012, 12:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The referenced bug suggests that it should be possible to individually \
select screen savers that are to be considered when the "Random" option is \
chosen. This patch implements that.
In order to avoid having to duplicate the complete saver tree view (and the code to \
generate it) within the random saver's setup mode, check boxes are added to the \
kcontrol saver list (with the exception of the random saver itself). The state of \
these is saved to the random saver's config file. This selection is in addition \
to the two options within the saver's setup dialogue, so if for example "Use \
OpenGL screen savers" is not checked than any OpenGL savers will be ignored even \
if their boxes are checked in the tree view.
(Submitting to kde-runtime, there is no kde-workspace group)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built saver and kcontrol module with these changes. Checked operation \
of kcontrol module, saving of settings in the config file and operation of the random \
saver.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=57572">57572</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/screensaver/scrnsave.h <span style="color: grey">(7c8deba)</span></li>
<li>kcontrol/screensaver/scrnsave.cpp <span style="color: \
grey">(c0507d4)</span></li>
<li>kscreensaver/krandom_screensaver/random.cpp <span style="color: \
grey">(4047184)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106524/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106524/s/733/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/21/screensaver-random_400x100.png" \
style="border: 1px black solid;" alt="kcmshell4 screensaver" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic