[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Use a qml based screen locker in place of the screensaver
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-09-16 11:26:42
Message-ID: 20120916112642.12960.61656 () vidsolbach ! de
[Download RAW message or body]
> On Sept. 16, 2012, 2 a.m., Michael Pyne wrote:
> > It took me awhile to get to do it properly but I've compiled the patche=
d kde-workspace and I have to say it's really impressive! No matter what I =
do I can't confuse the screen locker into showing even a flash of the deskt=
op underneath (even when using the X and KDE screensavers).
> > =
> > The only issues I've noticed are the kind of polish things. I would hig=
hly recommend ensuring that any old keyboard shortcut for screen locking co=
ntinues to work after this patch is applied. Ctrl-Alt-L doesn't work for me=
anymore and I'll poke around to see if the QAction has been renamed or som=
ething so that I can just re-change it back, but it would be best to be sea=
mless.
> > =
> > Also, when using lock screen with a screensaver, the screen locker does=
n't show the text labels (e.g. user name and "Password:" labels) until you =
click into the password line edit. (I'm using Caledonia Plasma theme right =
now, I'll try with an alternate one, just wanted to let you know). In addit=
ion it's not possible to type the password in without clicking into the lin=
e edit. I think the issue is as simple as focus not being applied to the li=
ne edit by default in this mode.
> > =
> > Overall it's good stuff from a "user" perspective (I haven't looked at =
the code at all unfortunately), just need to make sure it's possible to loc=
k screen and unlock without using the mouse. :)
> =
> Martin Gr=C3=A4=C3=9Flin wrote:
> > The only issues I've noticed are the kind of polish things. I would=
highly recommend ensuring that any old keyboard shortcut for screen lockin=
g continues to work after this patch is applied. Ctrl-Alt-L doesn't work fo=
r me anymore and I'll poke around to see if the QAction has been renamed or=
something so that I can just re-change it back, but it would be best to be=
seamless.
> =
> The problem is the way global shortcuts are handled. The shortcut is =
registered on KRunner and needs to be moved to the new framework. Probably =
the best solution is to keep the shortcut in KRunner and invoke the new loc=
ker through D-Bus. Of course for new installations the shortcut needs to be=
moved to the new architecture.
> =
> Marco Martin wrote:
> could a kconfig update script do the trick?
doubt it, have a look at plasma/desktop/shell/plasmaapp.cpp line 134 ff
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106124/#review19008
-----------------------------------------------------------
On Sept. 13, 2012, 12:17 p.m., Marco Martin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106124/
> -----------------------------------------------------------
> =
> (Updated Sept. 13, 2012, 12:17 p.m.)
> =
> =
> Review request for KDE Runtime and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Description
> -------
> =
> this is the finalization of the old "screenlocker" branch in workspace:
> the screen saver goes away (discussed at the time, about one year ago) an=
d the screen locker gets managed by ksmserver, with a greeter that has the =
ui dine in qml.
> The same qml ui gets loaded by the plasma based greeter when the "allow w=
idgets on screen locker" is enabled.
> the screensaver kcm is now called "Screen locker" and is way simpler, the=
screen saver chooser is gone from it.
> =
> =
> Diffs
> -----
> =
> kcontrol/screensaver/CMakeLists.txt e4dcc3a =
> kcontrol/screensaver/screensaver.ui 0ad5cd8 =
> kcontrol/screensaver/scrnsave.h 7c8deba =
> kcontrol/screensaver/scrnsave.cpp c0507d4 =
> krunner/CMakeLists.txt 21eac6f =
> krunner/dbus/org.freedesktop.ScreenSaver.xml 5efd943 =
> krunner/dbus/org.kde.screensaver.xml e700b88 =
> krunner/kcfg/kscreensaversettings.kcfg c8f76f3 =
> krunner/kcfg/kscreensaversettings.kcfgc af9133d =
> krunner/krunnerapp.h 040198d =
> krunner/krunnerapp.cpp eea6220 =
> krunner/lock/CMakeLists.txt cf9a67e =
> krunner/lock/autologout.h 0c444050 =
> krunner/lock/autologout.cc c86e29a =
> krunner/lock/config-krunner-lock.h.cmake 7bfdfd6 =
> krunner/lock/kscreenlocker.notifyrc cc5c3ea =
> krunner/lock/lockdlg.h f25e55f =
> krunner/lock/lockdlg.cc 14a9b34 =
> krunner/lock/lockprocess.h 8b6d9a8 =
> krunner/lock/lockprocess.cc 65c7f1d =
> krunner/lock/main.h 8a60353 =
> krunner/lock/main.cc 7b41024 =
> krunner/main.cpp 84a547b =
> krunner/screensaver/saverengine.h 3384d4a =
> krunner/screensaver/saverengine.cpp 4d90faa =
> krunner/screensaver/xautolock.h 3db3233 =
> krunner/screensaver/xautolock.cpp 7124215 =
> krunner/screensaver/xautolock_c.h 3b82f5c =
> krunner/screensaver/xautolock_diy.c b9df2f8 =
> krunner/screensaver/xautolock_engine.c d6d0cf5 =
> ksmserver/CMakeLists.txt 5f0fd34 =
> ksmserver/config-ksmserver.h.cmake 933da35 =
> ksmserver/main.cpp 430a61a =
> ksmserver/screenlocker/CMakeLists.txt PRE-CREATION =
> ksmserver/screenlocker/DESIGN PRE-CREATION =
> ksmserver/screenlocker/Messages.sh PRE-CREATION =
> ksmserver/screenlocker/autologout.h PRE-CREATION =
> ksmserver/screenlocker/autologout.cpp PRE-CREATION =
> ksmserver/screenlocker/data/CMakeLists.txt PRE-CREATION =
> ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp PRE-C=
REATION =
> ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd PRE-=
CREATION =
> ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml PRE-CREATIO=
N =
> ksmserver/screenlocker/dbus/org.kde.screensaver.xml PRE-CREATION =
> ksmserver/screenlocker/greeter/CMakeLists.txt PRE-CREATION =
> ksmserver/screenlocker/greeter/Messages.sh PRE-CREATION =
> ksmserver/screenlocker/greeter/greeter.h PRE-CREATION =
> ksmserver/screenlocker/greeter/greeter.cpp PRE-CREATION =
> ksmserver/screenlocker/greeter/greeterapp.h PRE-CREATION =
> ksmserver/screenlocker/greeter/greeterapp.cpp PRE-CREATION =
> ksmserver/screenlocker/greeter/main.cpp PRE-CREATION =
> ksmserver/screenlocker/greeter/screensaverwindow.h PRE-CREATION =
> ksmserver/screenlocker/greeter/screensaverwindow.cpp PRE-CREATION =
> ksmserver/screenlocker/greeter/sessions.h PRE-CREATION =
> ksmserver/screenlocker/greeter/sessions.cpp PRE-CREATION =
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/u=
i/Greeter.qml PRE-CREATION =
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/u=
i/SessionSwitching.qml PRE-CREATION =
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/u=
i/main.qml PRE-CREATION =
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.d=
esktop PRE-CREATION =
> ksmserver/screenlocker/interface.h PRE-CREATION =
> ksmserver/screenlocker/interface.cpp PRE-CREATION =
> ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION =
> ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION =
> ksmserver/screenlocker/kscreenlocker.notifyrc PRE-CREATION =
> ksmserver/screenlocker/ksldapp.h PRE-CREATION =
> ksmserver/screenlocker/ksldapp.cpp PRE-CREATION =
> ksmserver/screenlocker/lockwindow.h PRE-CREATION =
> ksmserver/screenlocker/lockwindow.cpp PRE-CREATION =
> ksmserver/server.h 8e54221 =
> ksmserver/server.cpp 7073fc9 =
> ksmserver/shutdown.cpp 6f298ec =
> kstyles/oxygen/oxygenmetrics.h 0643ae5 =
> plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a =
> plasma/generic/containmentactions/contextmenu/CMakeLists.txt 5433294 =
> plasma/generic/runners/sessions/CMakeLists.txt 1b8292c =
> plasma/screensaver/shell/BackgroundDialog.ui d6d2df7 =
> plasma/screensaver/shell/CMakeLists.txt 8ea4504 =
> plasma/screensaver/shell/backgrounddialog.cpp 1357a50 =
> plasma/screensaver/shell/main.cpp a1ae939 =
> plasma/screensaver/shell/plasmaapp.h 33137c2 =
> plasma/screensaver/shell/plasmaapp.cpp ade6c68 =
> plasma/screensaver/shell/savercorona.h 794e50c =
> plasma/screensaver/shell/savercorona.cpp 6f83859 =
> plasma/screensaver/shell/saverview.h 8500e47 =
> plasma/screensaver/shell/saverview.cpp b6a709e =
> powerdevil/daemon/CMakeLists.txt 35a4fd4 =
> startkde.cmake 36f23f1 =
> =
> Diff: http://git.reviewboard.kde.org/r/106124/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Marco Martin
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106124/">http://git.reviewboard.kde.org/r/106124/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 16th, 2012, 2 a.m., <b>Michael \
Pyne</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It took me awhile to get to do it properly but I've compiled the \
patched kde-workspace and I have to say it's really impressive! No matter what I \
do I can't confuse the screen locker into showing even a flash of the desktop \
underneath (even when using the X and KDE screensavers).
The only issues I've noticed are the kind of polish things. I would highly \
recommend ensuring that any old keyboard shortcut for screen locking continues to \
work after this patch is applied. Ctrl-Alt-L doesn't work for me anymore and \
I'll poke around to see if the QAction has been renamed or something so that I \
can just re-change it back, but it would be best to be seamless.
Also, when using lock screen with a screensaver, the screen locker doesn't show \
the text labels (e.g. user name and "Password:" labels) until you click \
into the password line edit. (I'm using Caledonia Plasma theme right now, \
I'll try with an alternate one, just wanted to let you know). In addition \
it's not possible to type the password in without clicking into the line edit. I \
think the issue is as simple as focus not being applied to the line edit by default \
in this mode.
Overall it's good stuff from a "user" perspective (I haven't looked \
at the code at all unfortunately), just need to make sure it's possible to lock \
screen and unlock without using the mouse. :)</pre> </blockquote>
<p>On September 16th, 2012, 8:10 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> The only issues \
I've noticed are the kind of polish things. I would highly recommend ensuring \
that any old keyboard shortcut for screen locking continues to work after this patch \
is applied. Ctrl-Alt-L doesn't work for me anymore and I'll poke around to \
see if the QAction has been renamed or something so that I can just re-change it \
back, but it would be best to be seamless.
The problem is the way global shortcuts are handled. The shortcut is registered on \
KRunner and needs to be moved to the new framework. Probably the best solution is to \
keep the shortcut in KRunner and invoke the new locker through D-Bus. Of course for \
new installations the shortcut needs to be moved to the new architecture.</pre> \
</blockquote>
<p>On September 16th, 2012, 10:55 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could a kconfig update \
script do the trick?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">doubt it, have a look at \
plasma/desktop/shell/plasmaapp.cpp line 134 ff</pre> <br />
<p>- Martin</p>
<br />
<p>On September 13th, 2012, 12:17 p.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Martin Gräßlin.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2012, 12:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is the finalization of the old "screenlocker" branch in \
workspace: the screen saver goes away (discussed at the time, about one year ago) and \
the screen locker gets managed by ksmserver, with a greeter that has the ui dine in \
qml. The same qml ui gets loaded by the plasma based greeter when the "allow \
widgets on screen locker" is enabled. the screensaver kcm is now called \
"Screen locker" and is way simpler, the screen saver chooser is gone from \
it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/screensaver/CMakeLists.txt <span style="color: \
grey">(e4dcc3a)</span></li>
<li>kcontrol/screensaver/screensaver.ui <span style="color: \
grey">(0ad5cd8)</span></li>
<li>kcontrol/screensaver/scrnsave.h <span style="color: grey">(7c8deba)</span></li>
<li>kcontrol/screensaver/scrnsave.cpp <span style="color: \
grey">(c0507d4)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(21eac6f)</span></li>
<li>krunner/dbus/org.freedesktop.ScreenSaver.xml <span style="color: \
grey">(5efd943)</span></li>
<li>krunner/dbus/org.kde.screensaver.xml <span style="color: \
grey">(e700b88)</span></li>
<li>krunner/kcfg/kscreensaversettings.kcfg <span style="color: \
grey">(c8f76f3)</span></li>
<li>krunner/kcfg/kscreensaversettings.kcfgc <span style="color: \
grey">(af9133d)</span></li>
<li>krunner/krunnerapp.h <span style="color: grey">(040198d)</span></li>
<li>krunner/krunnerapp.cpp <span style="color: grey">(eea6220)</span></li>
<li>krunner/lock/CMakeLists.txt <span style="color: grey">(cf9a67e)</span></li>
<li>krunner/lock/autologout.h <span style="color: grey">(0c444050)</span></li>
<li>krunner/lock/autologout.cc <span style="color: grey">(c86e29a)</span></li>
<li>krunner/lock/config-krunner-lock.h.cmake <span style="color: \
grey">(7bfdfd6)</span></li>
<li>krunner/lock/kscreenlocker.notifyrc <span style="color: \
grey">(cc5c3ea)</span></li>
<li>krunner/lock/lockdlg.h <span style="color: grey">(f25e55f)</span></li>
<li>krunner/lock/lockdlg.cc <span style="color: grey">(14a9b34)</span></li>
<li>krunner/lock/lockprocess.h <span style="color: grey">(8b6d9a8)</span></li>
<li>krunner/lock/lockprocess.cc <span style="color: grey">(65c7f1d)</span></li>
<li>krunner/lock/main.h <span style="color: grey">(8a60353)</span></li>
<li>krunner/lock/main.cc <span style="color: grey">(7b41024)</span></li>
<li>krunner/main.cpp <span style="color: grey">(84a547b)</span></li>
<li>krunner/screensaver/saverengine.h <span style="color: \
grey">(3384d4a)</span></li>
<li>krunner/screensaver/saverengine.cpp <span style="color: \
grey">(4d90faa)</span></li>
<li>krunner/screensaver/xautolock.h <span style="color: grey">(3db3233)</span></li>
<li>krunner/screensaver/xautolock.cpp <span style="color: \
grey">(7124215)</span></li>
<li>krunner/screensaver/xautolock_c.h <span style="color: \
grey">(3b82f5c)</span></li>
<li>krunner/screensaver/xautolock_diy.c <span style="color: \
grey">(b9df2f8)</span></li>
<li>krunner/screensaver/xautolock_engine.c <span style="color: \
grey">(d6d0cf5)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(5f0fd34)</span></li>
<li>ksmserver/config-ksmserver.h.cmake <span style="color: \
grey">(933da35)</span></li>
<li>ksmserver/main.cpp <span style="color: grey">(430a61a)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/DESIGN <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autologout.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autologout.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/dbus/org.kde.screensaver.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/screensaverwindow.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/screensaverwindow.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/sessions.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/sessions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/SessionSwitching.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/interface.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/interface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kscreenlocker.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/server.h <span style="color: grey">(8e54221)</span></li>
<li>ksmserver/server.cpp <span style="color: grey">(7073fc9)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(6f298ec)</span></li>
<li>kstyles/oxygen/oxygenmetrics.h <span style="color: grey">(0643ae5)</span></li>
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(4b0d32a)</span></li>
<li>plasma/generic/containmentactions/contextmenu/CMakeLists.txt <span style="color: \
grey">(5433294)</span></li>
<li>plasma/generic/runners/sessions/CMakeLists.txt <span style="color: \
grey">(1b8292c)</span></li>
<li>plasma/screensaver/shell/BackgroundDialog.ui <span style="color: \
grey">(d6d2df7)</span></li>
<li>plasma/screensaver/shell/CMakeLists.txt <span style="color: \
grey">(8ea4504)</span></li>
<li>plasma/screensaver/shell/backgrounddialog.cpp <span style="color: \
grey">(1357a50)</span></li>
<li>plasma/screensaver/shell/main.cpp <span style="color: \
grey">(a1ae939)</span></li>
<li>plasma/screensaver/shell/plasmaapp.h <span style="color: \
grey">(33137c2)</span></li>
<li>plasma/screensaver/shell/plasmaapp.cpp <span style="color: \
grey">(ade6c68)</span></li>
<li>plasma/screensaver/shell/savercorona.h <span style="color: \
grey">(794e50c)</span></li>
<li>plasma/screensaver/shell/savercorona.cpp <span style="color: \
grey">(6f83859)</span></li>
<li>plasma/screensaver/shell/saverview.h <span style="color: \
grey">(8500e47)</span></li>
<li>plasma/screensaver/shell/saverview.cpp <span style="color: \
grey">(b6a709e)</span></li>
<li>powerdevil/daemon/CMakeLists.txt <span style="color: grey">(35a4fd4)</span></li>
<li>startkde.cmake <span style="color: grey">(36f23f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic