[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Fix compilation of Dolphin with future kdelibs, v4.9.2 or higher
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2012-09-13 13:08:30
Message-ID: 20120913130830.29770.57586 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106438/
-----------------------------------------------------------
Review request for Dolphin and KDE Base Apps.
Description
-------
Since this is not my call to make. The attached patch fixes the compilation of \
Dolphin with KDE v4.9.2. It is effectively a fix of a prior commit \
http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b which \
will not work. See http://lists.kde.org/?l=kde-core-devel&m=134747823101454&w=2.
Diffs
-----
dolphin/src/CMakeLists.txt afc190f
dolphin/src/dolphinpart.h 0895686
dolphin/src/dolphinpart.cpp a7e8bff
dolphin/src/dolphinpart_ext.h PRE-CREATION
dolphin/src/dolphinpart_ext.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106438/diff/
Testing
-------
Thanks,
Dawit Alemayehu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106438/">http://git.reviewboard.kde.org/r/106438/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Dawit Alemayehu.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since this is not my call to make. The attached patch fixes the \
compilation of Dolphin with KDE v4.9.2. It is effectively a fix of a prior commit \
http://commits.kde.org/kde-baseapps/f0d5e062bf0452258d337d7dcb2edd2eefa1c37b which \
will not work. See http://lists.kde.org/?l=kde-core-devel&m=134747823101454&w=2.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(afc190f)</span></li>
<li>dolphin/src/dolphinpart.h <span style="color: grey">(0895686)</span></li>
<li>dolphin/src/dolphinpart.cpp <span style="color: grey">(a7e8bff)</span></li>
<li>dolphin/src/dolphinpart_ext.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dolphin/src/dolphinpart_ext.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106438/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic