[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Broken build of KDE Base Apps and unauthorized increase in dependency
From:       Dawit A <adawit () kde ! org>
Date:       2012-09-12 19:29:16
Message-ID: CALa28R7iMvY3Ls9+=Z8p43kqQSB7eksWkgmgtTb1wRvE=JCLbg () mail ! gmail ! com
[Download RAW message or body]

On Wed, Sep 12, 2012 at 2:50 PM, Allen Winter <winter@kde.org> wrote:

> On Wednesday 12 September 2012 08:12:58 PM Thomas Lübking wrote:
> > Am 12.09.2012, 20:04 Uhr, schrieb Dawit A <adawit@kde.org>:
> >
> > > Qt's moc processor does not
> > > seem to correctly handle #if macros.
> >
> > *sigh* "not at all" is more like it. **GREATSIGH***
> >
> > You'll have to move the class into an extra header and make it's
> inclusion
> > and moc invocation (latter in cmake) optional.
> >
> > **** DOUBLEGREATSIGH *****
>
> Dawit,
>
> I agree with Thomas.  Can you try to put the new class into a separate
> file?
> and then only compile the new file if kde version >= 4.9.2
>

Yes, I can and that is already what I have done locally to workaround the
shortcomings of the moc preprocessor. However, I though I would ask to see
if it would have been acceptable to avoid the addition of new files and use
of conditional macros by changing the minimum kdelibs version requirement
for the kde-baseapps git master repo instead. I guess the consensus is NO
and that is fine by me. I will commit what I have already done.

Regards,
Dawit A.

[Attachment #3 (text/html)]

<br><br><div class="gmail_quote">On Wed, Sep 12, 2012 at 2:50 PM, Allen Winter <span \
dir="ltr">&lt;<a href="mailto:winter@kde.org" \
target="_blank">winter@kde.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">

<div class="HOEnZb"><div class="h5">On Wednesday 12 September 2012 08:12:58 PM Thomas \
Lübking wrote:<br> &gt; Am 12.09.2012, 20:04 Uhr, schrieb Dawit A &lt;<a \
href="mailto:adawit@kde.org">adawit@kde.org</a>&gt;:<br> &gt;<br>
&gt; &gt; Qt&#39;s moc processor does not<br>
&gt; &gt; seem to correctly handle #if macros.<br>
&gt;<br>
&gt; *sigh* &quot;not at all&quot; is more like it. **GREATSIGH***<br>
&gt;<br>
&gt; You&#39;ll have to move the class into an extra header and make it&#39;s \
inclusion<br> &gt; and moc invocation (latter in cmake) optional.<br>
&gt;<br>
&gt; **** DOUBLEGREATSIGH *****<br>
<br>
</div></div>Dawit,<br>
<br>
I agree with Thomas.   Can you try to put the new class into a separate file?<br>
and then only compile the new file if kde version &gt;= \
4.9.2<br></blockquote><div><br></div><div>Yes, I can and that is already what I have \
done locally to workaround the shortcomings of the moc preprocessor. However, I \
though I would ask to see if it would have been acceptable to avoid the addition of \
new files and use of conditional macros by changing the minimum kdelibs version \
requirement for the kde-baseapps  git master  repo instead. I guess the consensus is \
NO and that is fine by me. I will commit what I have already done.</div>

<div><br></div><div>Regards,</div><div>Dawit A.</div></div>



[prev in list] [next in list] [prev in thread] [next in thread]