[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: kde-baseapps dependency on kdelibs changed in 4.9 branch?
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2012-09-11 10:49:47
Message-ID: CAFoZWWjzhi4116rpnoRDdm87cJuzX2=OLokiD4KNmU4x8q8UqA () mail ! gmail ! com
[Download RAW message or body]

Hi,

2012/9/11 Albert Astals Cid:
> It seems that the
> 
> set(KDE_MIN_VERSION "4.7.97")
> 
> that kde-baseapps mentions as required kdelibs version is not true anymore[1]
> and you now need unreleased kdelibs KDE/4.9 to build kde-baseapps KDE/4.9
> 
> Are we OK with such a dependency change?
> 
> Cheers,
> Albert
> 
> [1] http://quickgit.kde.org/index.php?p=kde-baseapps.git&a=commit&h=cb79ee6a881e2b4418bccc22480e3e269e5b0af9
> 

dependency changes in stable branches of kde-baseapps have already
been done in the past, see, e.g., [1], so I thought that Dawit's
commit, which fixes a regression in Konqueror's mime type filter, is
OK. However, the version check in the CMake file should be updated, of
course, and the kdelibs change required to build the current
kde-baseapps should probably also be merged into the KDE/4.10 and
master branches ASAP (I can't do it now because I'm not at my
development machine) to fix the build for people using these branches.

Best regards,
Frank

[1] https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/4caa285c065ea362ae52d93a567680513d8beb2a



[prev in list] [next in list] [prev in thread] [next in thread]