[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Config cleanup on removeActivity
From:       "makis marimpis" <makhsm () gmail ! com>
Date:       2012-09-01 15:44:03
Message-ID: 20120901154403.2537.43538 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106097/
-----------------------------------------------------------

(Updated Sept. 1, 2012, 3:44 p.m.)


Review request for KDE Runtime and Plasma.


Changes
-------

Aah, i didn't notice that this went to a plugin :}
In a similar way as before the config value is *supposed* to be removed.
The signal is emitted fine, the slot is triggered fine, but the "deleteEntr=
y" does nothing.

Any help is much appreciated :-)


Description
-------

Remove the related configuration entry (which holds the current desktop) wh=
en an activity is removed.


Diffs (updated)
-----

  src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp 568e0f9=
f489e19899dc73ec732488b2ee17c4e3f =

  src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.h 6bf08f0bd=
ec32d078071edb8556a33191ba08d23 =


Diff: http://git.reviewboard.kde.org/r/106097/diff/


Testing
-------

Yes


Thanks,

makis marimpis


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106097/">http://git.reviewboard.kde.org/r/106097/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime and Plasma.</div>
<div>By makis marimpis.</div>


<p style="color: grey;"><i>Updated Sept. 1, 2012, 3:44 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Aah, i didn&#39;t notice that this went to a plugin :} In a similar way \
as before the config value is *supposed* to be removed. The signal is emitted fine, \
the slot is triggered fine, but the &quot;deleteEntry&quot; does nothing.

Any help is much appreciated :-)</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove the related configuration entry (which holds the current desktop) \
when an activity is removed.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.cpp <span \
style="color: grey">(568e0f9f489e19899dc73ec732488b2ee17c4e3f)</span></li>

 <li>src/service/plugins/virtualdesktopswitch/virtualdesktopswitch.h <span \
style="color: grey">(6bf08f0bdec32d078071edb8556a33191ba08d23)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106097/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic