From kde-core-devel Thu Aug 30 08:42:28 2012 From: "Richard J. Moore" Date: Thu, 30 Aug 2012 08:42:28 +0000 To: kde-core-devel Subject: Re: Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase Message-Id: <20120830084228.27167.34798 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134631765519648 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8184915904196113636==" --===============8184915904196113636== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106268/#review18272 ----------------------------------------------------------- Ship it! Ship It! - Richard J. Moore On Aug. 29, 2012, 5:28 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106268/ > ----------------------------------------------------------- > = > (Updated Aug. 29, 2012, 5:28 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > The attached patch removes the code that performs SSL certificate host na= me mismatch check in TCPSlaveBase. Since we do not connect to servers using= IP address anymore, it is simply redundant to perform checks that are alre= ady done in Qt's SSL classes. > = > = > Diffs > ----- > = > kio/kio/tcpslavebase.cpp 3101bff = > = > Diff: http://git.reviewboard.kde.org/r/106268/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Dawit Alemayehu > = > --===============8184915904196113636== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106268/

Ship it!

Ship It!
 









- Richard J.






On August 29th, 2012, 5:28 p.m., Dawit Alemayehu wrote:









 

  


Review request for kdelibs.


By Dawit Alemayehu.




Updated Aug. 29, 2012, 5:28 p.m.








Descripti=
on 

 

 

  
   
The attached patch removes the code that performs SSL certif=
icate host name mismatch check in TCPSlaveBase. Since we do not connect to =
servers using IP address anymore, it is simply redundant to perform checks =
that are already done in Qt's SSL classes.

  		
 









Diffs=
 


    

 
  • kio/kio/tcpslavebase.cpp (3101bff)<=
/li>





View Diff
--===============8184915904196113636==--