--===============6792476879880571737== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Aug. 29, 2012, 4:14 p.m., Laszlo Papp wrote: > > Where can I see the diff? Since I opened the ticket for the wrong repository, I had to discard this r= equest and create a new one. See https://git.reviewboard.kde.org/r/106268/ = instead. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105976/#review18258 ----------------------------------------------------------- On Aug. 28, 2012, 11:35 p.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105976/ > ----------------------------------------------------------- > = > (Updated Aug. 28, 2012, 11:35 p.m.) > = > = > Review request for kdelibs. > = > = > Description > ------- > = > The attached patch removes the code that performs SSL certificate host na= me mismatch check in TCPSlaveBase. Since we do not connect to servers using= IP address anymore, it is simply redundant to perform checks that are alre= ady done in Qt's SSL classes. > = > = > Diffs > ----- > = > = > Diff: http://git.reviewboard.kde.org/r/105976/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Dawit Alemayehu > = > --===============6792476879880571737== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105976/

On August 29th, 2012, 4:14 p.m., Laszlo Pap= p wrote:

Where can=
 I see the diff?
Since I ope=
ned the ticket for the wrong repository, I had to discard this request and =
create a new one. See https://git.reviewboard.kde.org/r/106268/ instead.

- Dawit


On August 28th, 2012, 11:35 p.m., Dawit Alemayehu wrote:

Review request for kdelibs.
By Dawit Alemayehu.

Updated Aug. 28, 2012, 11:35 p.m.

Descripti= on

The attached patch removes the code that performs SSL certif=
icate host name mismatch check in TCPSlaveBase. Since we do not connect to =
servers using IP address anymore, it is simply redundant to perform checks =
that are already done in Qt's SSL classes.

Diffs=

View Diff

--===============6792476879880571737==--