From kde-core-devel Wed Aug 29 17:28:56 2012 From: "Dawit Alemayehu" Date: Wed, 29 Aug 2012 17:28:56 +0000 To: kde-core-devel Subject: Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase Message-Id: <20120829172856.11849.14010 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134626136805406 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5921543738732227751==" --===============5921543738732227751== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106268/ ----------------------------------------------------------- Review request for kdelibs. Description ------- The attached patch removes the code that performs SSL certificate host name= mismatch check in TCPSlaveBase. Since we do not connect to servers using I= P address anymore, it is simply redundant to perform checks that are alread= y done in Qt's SSL classes. Diffs ----- kio/kio/tcpslavebase.cpp 3101bff = Diff: http://git.reviewboard.kde.org/r/106268/diff/ Testing ------- Thanks, Dawit Alemayehu --===============5921543738732227751== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106268/

Review request for kdelibs.

By Dawit Alemayehu.

Descripti= on

The attached patch removes the code that performs SSL certif=
icate host name mismatch check in TCPSlaveBase. Since we do not connect to =
servers using IP address anymore, it is simply redundant to perform checks =
that are already done in Qt's SSL classes.

Diffs=

kio/kio/tcpslavebase.cpp (3101bff)<= /li>

View Diff

--===============5921543738732227751==--