[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Add spinlocks lock type, based on GCC intrisincs
From:       Michael Pyne <mpyne () kde ! org>
Date:       2012-08-27 22:20:15
Message-ID: 7171313.A9uvLEKRMH () midna
[Download RAW message or body]


On Monday, August 27, 2012 09:17:43 Thiago Macieira wrote:
> On domingo, 26 de agosto de 2012 19.09.15, Vadim Zhukov wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/106224/
> > -----------------------------------------------------------
> > 
> > Review request for kdelibs and Michael Pyne.
> > 
> > 
> > Description
> > -------
> > 
> > Add simple spin locking mechanism.
> > Written by Michael Pyne as from
> > https://bugs.kde.org/attachment.cgi?id=73282 , with some tweaking by me.
> > 
> > 
> > This addresses bug 305023.
> > 
> >     http://bugs.kde.org/show_bug.cgi?id=305023
> 
> Please use the Qt atomic types. Until GCC 4.7, they generate better code.

I agree, the reason it wasn't that way initially is mentioned in the 
discussion on the bug (but basically because you can't simply put 
QBasicAtomicInt in the union used to store the different lock types that are 
possible).

I have an idea of what to do to fix that but haven't had time to code it up.

Regards,
 - Michael Pyne
["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]