[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: konqueror: strip new line character from URL on paste automatically
From:       "David Faure" <faure () kde ! org>
Date:       2012-08-25 22:15:31
Message-ID: 20120825221531.14559.32078 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106184/#review18003
-----------------------------------------------------------

Ship it!


Looks good. I'm not sure where the need for ParagraphSeparator and LineSeparator comes from though, do \
websites actually use that?

- David Faure


On Aug. 25, 2012, 7:56 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106184/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 7:56 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> This patch removes line-breaking chars when an URL is entered.
> Very handy if you paste URLs from e.g. an email which shows the complete URL broken into multiple \
> lines. 
> 
> This addresses bug 159002.
> http://bugs.kde.org/show_bug.cgi?id=159002
> 
> 
> Diffs
> -----
> 
> konqueror/src/konqcombo.h 5c86fcd 
> konqueror/src/konqcombo.cpp 8169aec 
> 
> Diff: http://git.reviewboard.kde.org/r/106184/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106184/">http://git.reviewboard.kde.org/r/106184/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Looks good. I&#39;m not sure where the need for ParagraphSeparator \
and LineSeparator comes from though, do websites actually use that?</pre>  <br />







<p>- David</p>


<br />
<p>On August 25th, 2012, 7:56 p.m., Martin Koller wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Martin Koller.</div>


<p style="color: grey;"><i>Updated Aug. 25, 2012, 7:56 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes line-breaking chars when \
an URL is entered. Very handy if you paste URLs from e.g. an email which shows the complete URL broken \
into multiple lines.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=159002">159002</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>konqueror/src/konqcombo.h <span style="color: grey">(5c86fcd)</span></li>

 <li>konqueror/src/konqcombo.cpp <span style="color: grey">(8169aec)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106184/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic