[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: Use a qml based screen locker in place of the screensaver
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-08-22 18:07:14
Message-ID: 20120822180714.15399.62524 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106124/
-----------------------------------------------------------
Review request for KDE Runtime.
Description
-------
this is the finalization of the old "screenlocker" branch in workspace:
the screen saver goes away (discussed at the time, about one year ago) and =
the screen locker gets managed by ksmserver, with a greeter that has the ui=
dine in qml.
The same qml ui gets loaded by the plasma based greeter when the "allow wid=
gets on screen locker" is enabled.
the screensaver kcm is now called "Screen locker" and is way simpler, the s=
creen saver chooser is gone from it.
Diffs
-----
kcontrol/screensaver/CMakeLists.txt e4dcc3a =
kcontrol/screensaver/Messages.sh 5c727f2 =
kcontrol/screensaver/config-screensaver.h.cmake 9a789fc =
kcontrol/screensaver/kssmonitor.h 0cf5162 =
kcontrol/screensaver/kswidget.h b4631bd =
kcontrol/screensaver/kswidget.cpp 29f78fd =
kcontrol/screensaver/saverconfig.h c422625 =
kcontrol/screensaver/saverconfig.cpp 089068f =
kcontrol/screensaver/screenlocker.desktop PRE-CREATION =
kcontrol/screensaver/screenlocker.ui PRE-CREATION =
kcontrol/screensaver/screensaver.desktop aa1a861 =
kcontrol/screensaver/screensaver.ui 0ad5cd8 =
kcontrol/screensaver/scrnsave.h 7c8deba =
kcontrol/screensaver/scrnsave.cpp c0507d4 =
kcontrol/screensaver/testwin.h 46b9aa7 =
kcontrol/screensaver/testwin.cpp e8ea014 =
krunner/CMakeLists.txt 21eac6f =
krunner/dbus/org.freedesktop.ScreenSaver.xml 5efd943 =
krunner/dbus/org.kde.screensaver.xml e700b88 =
krunner/kcfg/kscreensaversettings.kcfg c8f76f3 =
krunner/kcfg/kscreensaversettings.kcfgc af9133d =
krunner/krunnerapp.h 040198d =
krunner/krunnerapp.cpp eea6220 =
krunner/lock/CMakeLists.txt cf9a67e =
krunner/lock/autologout.h 0c444050 =
krunner/lock/autologout.cc c86e29a =
krunner/lock/config-krunner-lock.h.cmake 7bfdfd6 =
krunner/lock/kscreenlocker.notifyrc 14e37ec =
krunner/lock/lockdlg.h f25e55f =
krunner/lock/lockdlg.cc 14a9b34 =
krunner/lock/lockprocess.h 8b6d9a8 =
krunner/lock/lockprocess.cc 65c7f1d =
krunner/lock/main.h 8a60353 =
krunner/lock/main.cc 7b41024 =
krunner/main.cpp 84a547b =
krunner/screensaver/saverengine.h 3384d4a =
krunner/screensaver/saverengine.cpp 4d90faa =
krunner/screensaver/xautolock.h 3db3233 =
krunner/screensaver/xautolock.cpp 7124215 =
krunner/screensaver/xautolock_c.h 3b82f5c =
krunner/screensaver/xautolock_diy.c b9df2f8 =
krunner/screensaver/xautolock_engine.c d6d0cf5 =
ksmserver/CMakeLists.txt 5f0fd34 =
ksmserver/config-ksmserver.h.cmake 933da35 =
ksmserver/main.cpp 430a61a =
ksmserver/screenlocker/CMakeLists.txt PRE-CREATION =
ksmserver/screenlocker/Messages.sh PRE-CREATION =
ksmserver/screenlocker/autologout.h PRE-CREATION =
ksmserver/screenlocker/autologout.cpp PRE-CREATION =
ksmserver/screenlocker/data/CMakeLists.txt PRE-CREATION =
ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp PRE-CRE=
ATION =
ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd PRE-CR=
EATION =
ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml PRE-CREATION =
ksmserver/screenlocker/dbus/org.kde.screensaver.xml PRE-CREATION =
ksmserver/screenlocker/greeter/CMakeLists.txt PRE-CREATION =
ksmserver/screenlocker/greeter/Messages.sh PRE-CREATION =
ksmserver/screenlocker/greeter/greeter.h PRE-CREATION =
ksmserver/screenlocker/greeter/greeter.cpp PRE-CREATION =
ksmserver/screenlocker/greeter/greeterapp.h PRE-CREATION =
ksmserver/screenlocker/greeter/greeterapp.cpp PRE-CREATION =
ksmserver/screenlocker/greeter/main.cpp PRE-CREATION =
ksmserver/screenlocker/greeter/sessions.h PRE-CREATION =
ksmserver/screenlocker/greeter/sessions.cpp PRE-CREATION =
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/=
Greeter.qml PRE-CREATION =
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/=
SessionSwitching.qml PRE-CREATION =
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/=
main.qml PRE-CREATION =
ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.des=
ktop PRE-CREATION =
ksmserver/screenlocker/interface.h PRE-CREATION =
ksmserver/screenlocker/interface.cpp PRE-CREATION =
ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION =
ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION =
ksmserver/screenlocker/kscreenlocker.notifyrc PRE-CREATION =
ksmserver/screenlocker/ksldapp.h PRE-CREATION =
ksmserver/screenlocker/ksldapp.cpp PRE-CREATION =
ksmserver/screenlocker/lockwindow.h PRE-CREATION =
ksmserver/screenlocker/lockwindow.cpp PRE-CREATION =
ksmserver/server.h 8e54221 =
ksmserver/server.cpp 7073fc9 =
ksmserver/shutdown.cpp 6f298ec =
plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a =
plasma/generic/containmentactions/contextmenu/CMakeLists.txt 5433294 =
plasma/generic/runners/sessions/CMakeLists.txt 1b8292c =
plasma/screensaver/shell/BackgroundDialog.ui d6d2df7 =
plasma/screensaver/shell/CMakeLists.txt 8ea4504 =
plasma/screensaver/shell/backgrounddialog.cpp 1357a50 =
plasma/screensaver/shell/main.cpp a1ae939 =
plasma/screensaver/shell/plasmaapp.cpp ade6c68 =
plasma/screensaver/shell/qml/lockscreen.qml PRE-CREATION =
plasma/screensaver/shell/savercorona.h 794e50c =
plasma/screensaver/shell/savercorona.cpp 6f83859 =
plasma/screensaver/shell/saverview.cpp b6a709e =
powerdevil/daemon/CMakeLists.txt 35a4fd4 =
startkde.cmake 36f23f1 =
Diff: http://git.reviewboard.kde.org/r/106124/diff/
Testing
-------
Thanks,
Marco Martin
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106124/">http://git.reviewboard.kde.org/r/106124/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Marco Martin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">this is the finalization of the old "screenlocker" branch in \
workspace: the screen saver goes away (discussed at the time, about one year ago) and \
the screen locker gets managed by ksmserver, with a greeter that has the ui dine in \
qml. The same qml ui gets loaded by the plasma based greeter when the "allow \
widgets on screen locker" is enabled. the screensaver kcm is now called \
"Screen locker" and is way simpler, the screen saver chooser is gone from \
it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/screensaver/CMakeLists.txt <span style="color: \
grey">(e4dcc3a)</span></li>
<li>kcontrol/screensaver/Messages.sh <span style="color: grey">(5c727f2)</span></li>
<li>kcontrol/screensaver/config-screensaver.h.cmake <span style="color: \
grey">(9a789fc)</span></li>
<li>kcontrol/screensaver/kssmonitor.h <span style="color: \
grey">(0cf5162)</span></li>
<li>kcontrol/screensaver/kswidget.h <span style="color: grey">(b4631bd)</span></li>
<li>kcontrol/screensaver/kswidget.cpp <span style="color: \
grey">(29f78fd)</span></li>
<li>kcontrol/screensaver/saverconfig.h <span style="color: \
grey">(c422625)</span></li>
<li>kcontrol/screensaver/saverconfig.cpp <span style="color: \
grey">(089068f)</span></li>
<li>kcontrol/screensaver/screenlocker.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/screensaver/screenlocker.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcontrol/screensaver/screensaver.desktop <span style="color: \
grey">(aa1a861)</span></li>
<li>kcontrol/screensaver/screensaver.ui <span style="color: \
grey">(0ad5cd8)</span></li>
<li>kcontrol/screensaver/scrnsave.h <span style="color: grey">(7c8deba)</span></li>
<li>kcontrol/screensaver/scrnsave.cpp <span style="color: \
grey">(c0507d4)</span></li>
<li>kcontrol/screensaver/testwin.h <span style="color: grey">(46b9aa7)</span></li>
<li>kcontrol/screensaver/testwin.cpp <span style="color: grey">(e8ea014)</span></li>
<li>krunner/CMakeLists.txt <span style="color: grey">(21eac6f)</span></li>
<li>krunner/dbus/org.freedesktop.ScreenSaver.xml <span style="color: \
grey">(5efd943)</span></li>
<li>krunner/dbus/org.kde.screensaver.xml <span style="color: \
grey">(e700b88)</span></li>
<li>krunner/kcfg/kscreensaversettings.kcfg <span style="color: \
grey">(c8f76f3)</span></li>
<li>krunner/kcfg/kscreensaversettings.kcfgc <span style="color: \
grey">(af9133d)</span></li>
<li>krunner/krunnerapp.h <span style="color: grey">(040198d)</span></li>
<li>krunner/krunnerapp.cpp <span style="color: grey">(eea6220)</span></li>
<li>krunner/lock/CMakeLists.txt <span style="color: grey">(cf9a67e)</span></li>
<li>krunner/lock/autologout.h <span style="color: grey">(0c444050)</span></li>
<li>krunner/lock/autologout.cc <span style="color: grey">(c86e29a)</span></li>
<li>krunner/lock/config-krunner-lock.h.cmake <span style="color: \
grey">(7bfdfd6)</span></li>
<li>krunner/lock/kscreenlocker.notifyrc <span style="color: \
grey">(14e37ec)</span></li>
<li>krunner/lock/lockdlg.h <span style="color: grey">(f25e55f)</span></li>
<li>krunner/lock/lockdlg.cc <span style="color: grey">(14a9b34)</span></li>
<li>krunner/lock/lockprocess.h <span style="color: grey">(8b6d9a8)</span></li>
<li>krunner/lock/lockprocess.cc <span style="color: grey">(65c7f1d)</span></li>
<li>krunner/lock/main.h <span style="color: grey">(8a60353)</span></li>
<li>krunner/lock/main.cc <span style="color: grey">(7b41024)</span></li>
<li>krunner/main.cpp <span style="color: grey">(84a547b)</span></li>
<li>krunner/screensaver/saverengine.h <span style="color: \
grey">(3384d4a)</span></li>
<li>krunner/screensaver/saverengine.cpp <span style="color: \
grey">(4d90faa)</span></li>
<li>krunner/screensaver/xautolock.h <span style="color: grey">(3db3233)</span></li>
<li>krunner/screensaver/xautolock.cpp <span style="color: \
grey">(7124215)</span></li>
<li>krunner/screensaver/xautolock_c.h <span style="color: \
grey">(3b82f5c)</span></li>
<li>krunner/screensaver/xautolock_diy.c <span style="color: \
grey">(b9df2f8)</span></li>
<li>krunner/screensaver/xautolock_engine.c <span style="color: \
grey">(d6d0cf5)</span></li>
<li>ksmserver/CMakeLists.txt <span style="color: grey">(5f0fd34)</span></li>
<li>ksmserver/config-ksmserver.h.cmake <span style="color: \
grey">(933da35)</span></li>
<li>ksmserver/main.cpp <span style="color: grey">(430a61a)</span></li>
<li>ksmserver/screenlocker/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autologout.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/autologout.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/dbus/org.freedesktop.ScreenSaver.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/dbus/org.kde.screensaver.xml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeter.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/sessions.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/sessions.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/SessionSwitching.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/metadata.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/interface.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/interface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kcfg/kscreensaversettings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/kscreenlocker.notifyrc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/server.h <span style="color: grey">(8e54221)</span></li>
<li>ksmserver/server.cpp <span style="color: grey">(7073fc9)</span></li>
<li>ksmserver/shutdown.cpp <span style="color: grey">(6f298ec)</span></li>
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(4b0d32a)</span></li>
<li>plasma/generic/containmentactions/contextmenu/CMakeLists.txt <span style="color: \
grey">(5433294)</span></li>
<li>plasma/generic/runners/sessions/CMakeLists.txt <span style="color: \
grey">(1b8292c)</span></li>
<li>plasma/screensaver/shell/BackgroundDialog.ui <span style="color: \
grey">(d6d2df7)</span></li>
<li>plasma/screensaver/shell/CMakeLists.txt <span style="color: \
grey">(8ea4504)</span></li>
<li>plasma/screensaver/shell/backgrounddialog.cpp <span style="color: \
grey">(1357a50)</span></li>
<li>plasma/screensaver/shell/main.cpp <span style="color: \
grey">(a1ae939)</span></li>
<li>plasma/screensaver/shell/plasmaapp.cpp <span style="color: \
grey">(ade6c68)</span></li>
<li>plasma/screensaver/shell/qml/lockscreen.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/screensaver/shell/savercorona.h <span style="color: \
grey">(794e50c)</span></li>
<li>plasma/screensaver/shell/savercorona.cpp <span style="color: \
grey">(6f83859)</span></li>
<li>plasma/screensaver/shell/saverview.cpp <span style="color: \
grey">(b6a709e)</span></li>
<li>powerdevil/daemon/CMakeLists.txt <span style="color: grey">(35a4fd4)</span></li>
<li>startkde.cmake <span style="color: grey">(36f23f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic