[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: avoid duplicate entries in konqueror address completion list
From: "Martin Koller" <kollix () aon ! at>
Date: 2012-08-15 19:14:26
Message-ID: 20120815191426.31439.4466 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 15, 2012, 7:05 p.m., Mark Gaiser wrote:
> > I don't know the konqueror code, but i don't think this is the right wa=
y to do it. Imho it shouldn't even be inserted in the first place. Though s=
omeone else would have to confirm.
Well, I see it this way: there is the list of completion strings coming fro=
m the completer.
And there is the history.
Both things shall be shown here.
"should not be inserted" is what this patch is about, by filtering the ones=
which are in both lists.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106046/#review17474
-----------------------------------------------------------
On Aug. 15, 2012, 5:24 p.m., Martin Koller wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106046/
> -----------------------------------------------------------
> =
> (Updated Aug. 15, 2012, 5:24 p.m.)
> =
> =
> Review request for KDE Base Apps.
> =
> =
> Description
> -------
> =
> When opening e.g. "man:mdoc.samples" as URL in konqueror, the next time I=
type "man:mdoc" konqueror shows "man:mdoc, man:mdoc.samples, man:mdoc.samp=
les" in the completion box (history list is added to completion list giving=
duplicates)
> This patch simply avoids having duplicates in that list.
> =
> =
> Diffs
> -----
> =
> konqueror/src/konqmainwindow.cpp c5468f9 =
> =
> Diff: http://git.reviewboard.kde.org/r/106046/diff/
> =
> =
> Testing
> -------
> =
> yes
> =
> =
> Thanks,
> =
> Martin Koller
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106046/">http://git.reviewboard.kde.org/r/106046/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 15th, 2012, 7:05 p.m., <b>Mark \
Gaiser</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't know the konqueror code, but i don't think this is the \
right way to do it. Imho it shouldn't even be inserted in the first place. Though \
someone else would have to confirm.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I see it this way: \
there is the list of completion strings coming from the completer. And there is the \
history. Both things shall be shown here.
"should not be inserted" is what this patch is about, by filtering the ones \
which are in both lists.</pre> <br />
<p>- Martin</p>
<br />
<p>On August 15th, 2012, 5:24 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2012, 5:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When opening e.g. "man:mdoc.samples" as URL in konqueror, the \
next time I type "man:mdoc" konqueror shows "man:mdoc, \
man:mdoc.samples, man:mdoc.samples" in the completion box (history list is added \
to completion list giving duplicates) This patch simply avoids having duplicates in \
that list.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(c5468f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106046/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic