From kde-core-devel Wed Aug 15 19:05:11 2012 From: "Mark Gaiser" Date: Wed, 15 Aug 2012 19:05:11 +0000 To: kde-core-devel Subject: Re: Review Request: avoid duplicate entries in konqueror address completion list Message-Id: <20120815190511.30199.55412 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=134505781127872 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6376653276926664606==" --===============6376653276926664606== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106046/#review17474 ----------------------------------------------------------- I don't know the konqueror code, but i don't think this is the right way to= do it. Imho it shouldn't even be inserted in the first place. Though someo= ne else would have to confirm. - Mark Gaiser On Aug. 15, 2012, 5:24 p.m., Martin Koller wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106046/ > ----------------------------------------------------------- > = > (Updated Aug. 15, 2012, 5:24 p.m.) > = > = > Review request for KDE Base Apps. > = > = > Description > ------- > = > When opening e.g. "man:mdoc.samples" as URL in konqueror, the next time I= type "man:mdoc" konqueror shows "man:mdoc, man:mdoc.samples, man:mdoc.samp= les" in the completion box (history list is added to completion list giving= duplicates) > This patch simply avoids having duplicates in that list. > = > = > Diffs > ----- > = > konqueror/src/konqmainwindow.cpp c5468f9 = > = > Diff: http://git.reviewboard.kde.org/r/106046/diff/ > = > = > Testing > ------- > = > yes > = > = > Thanks, > = > Martin Koller > = > --===============6376653276926664606== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106046/

I don'=
t know the konqueror code, but i don't think this is the right way to d=
o it. Imho it shouldn't even be inserted in the first place. Though som=
eone else would have to confirm.

- Mark

On August 15th, 2012, 5:24 p.m., Martin Koller wrote:

Review request for KDE Base Apps.

By Martin Koller.

Updated Aug. 15, 2012, 5:24 p.m.

Descripti= on

When opening e.g. "man:mdoc.samples" as URL in kon=
queror, the next time I type "man:mdoc" konqueror shows "man=
:mdoc, man:mdoc.samples, man:mdoc.samples" in the completion box (hist=
ory list is added to completion list giving duplicates)
This patch simply avoids having duplicates in that list.

Testing <= /h1>

yes

Diffs=

konqueror/src/konqmainwindow.cpp (c5468f9)=

View Diff

--===============6376653276926664606==--