'Re: Review Request: Make kcodecs framework build standalone'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request: Make kcodecs framework build standalone
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2012-08-08 19:20:31
Message-ID: 20120808192031.6509.11133 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105860/
-----------------------------------------------------------

(Updated Aug. 8, 2012, 7:20 p.m.)

Review request for KDE Frameworks and David Faure.

Changes
-------

Fix David's comments about commenting and undef.

Description
-------

Make it possible to build kcodecs independently of the whole kdelibs-framew=
orks tree.

Diffs (updated)
-----

  tier1/kcodecs/CMakeLists.txt 22463ca0345e6d50384c17bf5f43824e3445b55f =

  tier1/kcodecs/src/kcharsets.cpp c64aa12361583cd9184bc39495c7149e6b0d7796 =

  tier1/kcodecs/src/kencodingprober.cpp 1dad3272986c2b0c693cd1bbf49fd400553=
00e39 =

Diff: http://git.reviewboard.kde.org/r/105860/diff/

Testing
-------

Works for me, both standalone and as part of kdelibs

Thanks,

George Goldberg

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105860/">http://git.reviewboard.kde.org/r/105860/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks and David Faure.</div>
<div>By George Goldberg.</div>

<p style="color: grey;"><i>Updated Aug. 8, 2012, 7:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix David&#39;s comments about commenting and undef.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make it possible to build kcodecs independently of the whole \
kdelibs-frameworks tree.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works for me, both standalone and as part of kdelibs</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>tier1/kcodecs/CMakeLists.txt <span style="color: \
grey">(22463ca0345e6d50384c17bf5f43824e3445b55f)</span></li>

 <li>tier1/kcodecs/src/kcharsets.cpp <span style="color: \
grey">(c64aa12361583cd9184bc39495c7149e6b0d7796)</span></li>

 <li>tier1/kcodecs/src/kencodingprober.cpp <span style="color: \
grey">(1dad3272986c2b0c693cd1bbf49fd40055300e39)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105860/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 