[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Fix hang in kcm_useraccount
From:       "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date:       2012-08-07 18:27:18
Message-ID: 20120807182718.17466.18569 () vidsolbach ! de
[Download RAW message or body]

> On Aug. 6, 2012, 4:55 p.m., Rolf Eike Beer wrote:
> > kdepasswd/kcm/chfnprocess.cpp, line 68
> > <http://git.reviewboard.kde.org/r/105895/diff/1/?file=76314#file76314line68>
> > 
> > Why unread the line if you read it again just 3 lines below? Why not just put the \
> > readline() below in an else clause?
> 
> Michael Palimaka wrote:
> After further thought, will readLine() work correctly after readAll()? That is the \
> reason I unread in the original diff.

Which may be absolutely true (no idea). But then it deserves a comment explaining why \
you do it, otherwise the next poor soul touching the code may do the same mistake \
again.


- Rolf Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/#review16985
-----------------------------------------------------------


On Aug. 6, 2012, 5:03 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105895/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 5:03 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> When changing the user's full name, chfn may not necessarily produce any output. \
> Since readLine blocks, the kcm may hang. 
> This change checks if chfn exited without output, and if so, use that exit status.
> 
> 
> This addresses bug 156396.
> http://bugs.kde.org/show_bug.cgi?id=156396
> 
> 
> Diffs
> -----
> 
> kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 
> 
> Diff: http://git.reviewboard.kde.org/r/105895/diff/
> 
> 
> Testing
> -------
> 
> On a PAM-enabled system:
> * Full name changed successfully when permitted by login.defs
> * Error presented and no change processed with prohibited by login.defs
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105895/">http://git.reviewboard.kde.org/r/105895/</a>
  </td>
    </tr>
   </table>
   <br />








<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 6th, 2012, 4:55 p.m., <b>Rolf Eike \
Beer</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/105895/diff/1/?file=76314#file76314line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdepasswd/kcm/chfnprocess.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
ChfnProcess::exec(const char *pass, const char *name)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">unreadLine</span><span class="p">(</span><span class="n">line</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why unread the line if \
you read it again just 3 lines below? Why not just put the readline() below in an \
else clause?</pre>  </blockquote>



 <p>On August 7th, 2012, 8:43 a.m., <b>Michael Palimaka</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After further thought, \
will readLine() work correctly after readAll()? That is the reason I unread in the \
original diff.</pre>  </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Which may \
be absolutely true (no idea). But then it deserves a comment explaining why you do \
it, otherwise the next poor soul touching the code may do the same mistake \
again.</pre> <br />




<p>- Rolf Eike</p>


<br />
<p>On August 6th, 2012, 5:03 p.m., Michael Palimaka wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps.</div>
<div>By Michael Palimaka.</div>


<p style="color: grey;"><i>Updated Aug. 6, 2012, 5:03 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When changing the user&#39;s full name, chfn may not necessarily produce \
any output. Since readLine blocks, the kcm may hang.

This change checks if chfn exited without output, and if so, use that exit \
status.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">On a PAM-enabled system:
* Full name changed successfully when permitted by login.defs
* Error presented and no change processed with prohibited by login.defs</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=156396">156396</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kdepasswd/kcm/chfnprocess.cpp <span style="color: \
grey">(9f75d4aa75b41acec84e7798c789d4226ca3fab9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105895/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic