[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Support for GRUB2 submenus
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2012-08-07 17:46:29
Message-ID: 20120807174629.11066.78709 () vidsolbach ! de
[Download RAW message or body]
> On Aug. 7, 2012, 4:42 p.m., Oswald Buddenhagen wrote:
> > Ship It!
>
> Konstantinos Smanis wrote:
> What should I commit to which branches? 4.8.5 is out, so any commits in the 4.8.x \
> branch won't ever be officially released. I guess the kdm part can affect all the \
> rest (4.9.x, master) branches.
well, you can still push to 4.8 - distributors will pick up the "fix".
i don't think you'll have a problem forward-porting the whole thing to 4.9 - the \
change to lamarque's code is minimal. you know where to get it reviewed. ;)
- Oswald
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105563/#review17055
-----------------------------------------------------------
On Aug. 7, 2012, 3:56 p.m., Konstantinos Smanis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105563/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2012, 3:56 p.m.)
>
>
> Review request for KDE Runtime and Oswald Buddenhagen.
>
>
> Description
> -------
>
> Recent versions of GRUB2 introduce submenus which allow for nesting levels to \
> appear (instead of the flat list in the past). This patch consists of two parts: \
> the parsing part in KDM (bootman.c) and creating a menu structure from the parsed \
> list in ksmserver (shutdowndlg.*) The parsing part produces a list like this:
>
> Gentoo GNU/Linux
> Advanced options for Gentoo GNU/Linux
> Advanced options for Gentoo GNU/Linux>Gentoo GNU/Linux, with Linux 3.4.4
> Advanced options for Gentoo GNU/Linux>Gentoo GNU/Linux, with Linux 3.4.4 (recovery \
> mode) Windows 7 (loader) (on /dev/sda2)
> ???? ?????????
>
> which is then converted into the menu structure. These full identifiers can be \
> properly used with `grub2-reboot`.
> More info about submenus: http://ubuntuforums.org/showthread.php?p=10720316
> Also check the related bug.
>
> The parsing part of the patch can be applied in the KDE/4.9 and master branches as \
> well (tested and working in KDE 4.8.95 and 4.9.x). ksmserver has migrated to QML \
> since then however, and the menu structure has to wait. Currently it looks like \
> this: http://i50.tinypic.com/96bw35.png Related ML-discussion: \
> http://lists.kde.org/?l=kde-core-devel&m=134160279511422&w=2
> Update: There is a proper fix now for KDE/4.9 and master: \
> https://git.reviewboard.kde.org/r/105568/
>
> This addresses bug 297209.
> http://bugs.kde.org/show_bug.cgi?id=297209
>
>
> Diffs
> -----
>
> kdm/backend/bootman.c 8b834d2
> kdm/backend/ctrl.c 5d219fe
> kdm/backend/dm.h 13e7b45
> kdm/backend/util.c 6cd93ef
> ksmserver/shutdowndlg.cpp a09a1a7
>
> Diff: http://git.reviewboard.kde.org/r/105563/diff/
>
>
> Testing
> -------
>
> Works with the menu file produced in my system with `grub2-mkconfig`.
> Also works with a custom menu file I made (as shown in the second screenshot).
>
>
> Screenshots
> -----------
>
> Distribution's stock menu file
> http://git.reviewboard.kde.org/r/105563/s/633/
> A custom menu file for testing
> http://git.reviewboard.kde.org/r/105563/s/634/
>
>
> Thanks,
>
> Konstantinos Smanis
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105563/">http://git.reviewboard.kde.org/r/105563/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 7th, 2012, 4:42 p.m., <b>Oswald \
Buddenhagen</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On August 7th, 2012, 5:14 p.m., <b>Konstantinos Smanis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What should I commit to \
which branches? 4.8.5 is out, so any commits in the 4.8.x branch won't ever be \
officially released. I guess the kdm part can affect all the rest (4.9.x, master) \
branches.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well, you can still push \
to 4.8 - distributors will pick up the "fix".
i don't think you'll have a problem forward-porting the whole thing to 4.9 - \
the change to lamarque's code is minimal. you know where to get it reviewed. \
;)</pre> <br />
<p>- Oswald</p>
<br />
<p>On August 7th, 2012, 3:56 p.m., Konstantinos Smanis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Oswald Buddenhagen.</div>
<div>By Konstantinos Smanis.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2012, 3:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Recent versions of GRUB2 introduce submenus which allow for nesting \
levels to appear (instead of the flat list in the past). This patch consists of two \
parts: the parsing part in KDM (bootman.c) and creating a menu structure from the \
parsed list in ksmserver (shutdowndlg.*) The parsing part produces a list like this:
Gentoo GNU/Linux
Advanced options for Gentoo GNU/Linux
Advanced options for Gentoo GNU/Linux>Gentoo GNU/Linux, with Linux 3.4.4
Advanced options for Gentoo GNU/Linux>Gentoo GNU/Linux, with Linux 3.4.4 (recovery \
mode) Windows 7 (loader) (on /dev/sda2)
???? ?????????
which is then converted into the menu structure. These full identifiers can be \
properly used with `grub2-reboot`.
More info about submenus: http://ubuntuforums.org/showthread.php?p=10720316
Also check the related bug.
The parsing part of the patch can be applied in the KDE/4.9 and master branches as \
well (tested and working in KDE 4.8.95 and 4.9.x). ksmserver has migrated to QML \
since then however, and the menu structure has to wait. Currently it looks like this: \
http://i50.tinypic.com/96bw35.png Related ML-discussion: \
http://lists.kde.org/?l=kde-core-devel&m=134160279511422&w=2
Update: There is a proper fix now for KDE/4.9 and master: \
https://git.reviewboard.kde.org/r/105568/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works with the menu file produced in my system with `grub2-mkconfig`. \
Also works with a custom menu file I made (as shown in the second screenshot).</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297209">297209</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdm/backend/bootman.c <span style="color: grey">(8b834d2)</span></li>
<li>kdm/backend/ctrl.c <span style="color: grey">(5d219fe)</span></li>
<li>kdm/backend/dm.h <span style="color: grey">(13e7b45)</span></li>
<li>kdm/backend/util.c <span style="color: grey">(6cd93ef)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(a09a1a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105563/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/105563/s/633/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/13/snapshot5_400x100.png" \
style="border: 1px black solid;" alt="Distribution's stock menu file" /></a>
<a href="http://git.reviewboard.kde.org/r/105563/s/634/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/07/13/snapshot6_400x100.png" \
style="border: 1px black solid;" alt="A custom menu file for testing" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic