'Re: Review Request: kjs: Mark Date Infinity as invalid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: kjs: Mark Date Infinity as invalid
From:       "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date:       2012-07-06 18:30:08
Message-ID: 20120706183008.17520.31948 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105387/
-----------------------------------------------------------

(Updated July 6, 2012, 6:30 p.m.)


Review request for kdelibs.


Changes
-------

kjs: Mark Date Infinity as invalid & cleanup


Description
-------

kjs: Mark Date Infinity as invalid

we currently accept Infinity as a valid date, but its not, we even calc wit=
h it,
which may or may not lead to a result, but always to the wrong result.

The correct way it to just report it as invalid, as we do by remembering it=
 as NaN.


Diffs (updated)
-----

  kjs/date_object.cpp 8a1fc2c =


Diff: http://git.reviewboard.kde.org/r/105387/diff/


Testing
-------


Thanks,

Bernd Buschinski


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105387/">http://git.reviewboard.kde.org/r/105387/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>


<p style="color: grey;"><i>Updated July 6, 2012, 6:30 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Mark Date Infinity as invalid &amp; cleanup</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Mark Date Infinity as invalid

we currently accept Infinity as a valid date, but its not, we even calc with it,
which may or may not lead to a result, but always to the wrong result.

The correct way it to just report it as invalid, as we do by remembering it as \
NaN.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kjs/date_object.cpp <span style="color: grey">(8a1fc2c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105387/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic