[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String
From: "Maks Orlovich" <maksim () kde ! org>
Date: 2012-07-06 13:40:44
Message-ID: 20120706134044.23101.4698 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105391/#review15461
-----------------------------------------------------------
Ship it!
kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/105391/#comment12090>
I was thinking you could get rid of the if (element->isObject()) condit=
ional as well.
=
- Maks Orlovich
On July 4, 2012, 10:27 p.m., Bernd Buschinski wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105391/
> -----------------------------------------------------------
> =
> (Updated July 4, 2012, 10:27 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> kjs: Use toPrimitive in Array.join to get the correct String
> =
> the default value case for String is present here, as testcase S15.4.4.5_=
A3.2_T2 shows
> =
> =
> Diffs
> -----
> =
> kjs/array_object.cpp 0da29b0 =
> =
> Diff: http://git.reviewboard.kde.org/r/105391/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Bernd Buschinski
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105391/">http://git.reviewboard.kde.org/r/105391/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105391/diff/2/?file=71345#file71345line208" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/array_object.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">JSValue* ArrayProtoFunc::callAsFunction(ExecState* exec, JSObject* thisObj, const \
List& args)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">208</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">204</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was \
thinking you could get rid of the if (element->isObject()) conditional as well. \
</pre> </div>
<br />
<p>- Maks</p>
<br />
<p>On July 4th, 2012, 10:27 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated July 4, 2012, 10:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Use toPrimitive in Array.join to get the correct String
the default value case for String is present here, as testcase S15.4.4.5_A3.2_T2 \
shows</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/array_object.cpp <span style="color: grey">(0da29b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105391/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic