[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kjs: Implement Date.toISOString
From: "Maks Orlovich" <maksim () kde ! org>
Date: 2012-07-06 13:39:28
Message-ID: 20120706133928.23035.89402 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105386/#review15459
-----------------------------------------------------------
kjs/date_object.cpp
<http://git.reviewboard.kde.org/r/105386/#comment12089>
what if hour becomes negative here?
=
- Maks Orlovich
On June 29, 2012, 6:06 p.m., Bernd Buschinski wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105386/
> -----------------------------------------------------------
> =
> (Updated June 29, 2012, 6:06 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> kjs: Implement Date.toISOString
> =
> mostly copied from ToUTCString but with different format and behavior,
> YYYY-MM-DDTHH:mm:ss:sssZ and exception throwing on invalid date
> =
> =
> Diffs
> -----
> =
> kjs/date_object.h ed45720 =
> kjs/date_object.cpp 8a1fc2c =
> =
> Diff: http://git.reviewboard.kde.org/r/105386/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Bernd Buschinski
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105386/">http://git.reviewboard.kde.org/r/105386/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105386/diff/1/?file=70641#file70641line266" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/date_object.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static UString formatTimeISOVariant(const tm &t, bool utc, double \
ms)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">266</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">t</span><span class="p">.</span><span class="n">tm_hour</span> <span \
class="o">-</span> <span class="p">(</span><span class="n">offset</span> <span \
class="o">/</span> <span class="p">(</span><span class="mi">60</span><span \
class="o">*</span><span class="mi">60</span><span class="p">)),</span> <span \
class="n">t</span><span class="p">.</span><span class="n">tm_min</span> <span \
class="o">-</span> <span class="p">((</span><span class="n">offset</span> <span \
class="o">/</span> <span class="mi">60</span><span class="p">)</span> <span \
class="o">%</span> <span class="mi">60</span><span class="p">),</span> <span \
class="n">t</span><span class="p">.</span><span class="n">tm_sec</span><span \
class="p">,</span> <span class="kt">int</span><span class="p">(</span><span \
class="n">ms</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">what if \
hour becomes negative here? </pre>
</div>
<br />
<p>- Maks</p>
<br />
<p>On June 29th, 2012, 6:06 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated June 29, 2012, 6:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Implement Date.toISOString
mostly copied from ToUTCString but with different format and behavior,
YYYY-MM-DDTHH:mm:ss:sssZ and exception throwing on invalid date</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/date_object.h <span style="color: grey">(ed45720)</span></li>
<li>kjs/date_object.cpp <span style="color: grey">(8a1fc2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105386/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic