[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: proper fix for my inexcusable commit without review
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-06-29 16:22:36
Message-ID: 20120629162236.11940.7357 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105364/
-----------------------------------------------------------
(Updated June 29, 2012, 4:22 p.m.)
Review request for kdelibs.
Changes
-------
It is not possible to fix the memory leak in void KAction::setAuthAction(co=
nst QString &actionName) the way I tried.
kdelibs will have it until frameworks is ready.
Therefore, replace the delete by just two comments.
Description
-------
the action created locally in void KAction::setAuthAction(const QString &ac=
tionName) is deleted.
The others must be handled by the callers of void KAction::setAuthAction(KA=
uth::Action *action).
Diffs (updated)
-----
kdeui/actions/kaction.cpp 0f6343c =
Diff: http://git.reviewboard.kde.org/r/105364/diff/
Testing
-------
working with it this afternoon.
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105364/">http://git.reviewboard.kde.org/r/105364/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated June 29, 2012, 4:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It is not possible to fix the memory leak in void \
KAction::setAuthAction(const QString &actionName) the way I tried. kdelibs will \
have it until frameworks is ready. Therefore, replace the delete by just two \
comments.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the action created locally in void KAction::setAuthAction(const QString \
&actionName) is deleted. The others must be handled by the callers of void \
KAction::setAuthAction(KAuth::Action *action).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">working with it this afternoon.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/actions/kaction.cpp <span style="color: grey">(0f6343c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105364/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic