[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Added fallback for real username in kcm module to use KUser::FullName
From: "Raphael Kubo da Costa" <rakuco () freebsd ! org>
Date: 2012-06-27 0:41:02
Message-ID: 20120627004102.2112.90745 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104965/#review15187
-----------------------------------------------------------
kdepasswd/kcm/main.cpp
<http://git.reviewboard.kde.org/r/104965/#comment11891>
Nit: 'realName' is better, as these are separate words.
kdepasswd/kcm/main.cpp
<http://git.reviewboard.kde.org/r/104965/#comment11892>
Please follow kdelibs' coding style here (4-space indentation, surrounding braces \
even for single-line statements):
if (foo) {
bar();
}
- Raphael Kubo da Costa
On May 16, 2012, 7:09 a.m., Aleksey Yermakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104965/
> -----------------------------------------------------------
>
> (Updated May 16, 2012, 7:09 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> Added fallback for real username in kcm module.
>
> Really helps in issues like this: http://bugs.rosalinux.ru/show_bug.cgi?id=179
>
> Besides, such method seems natural, considering that change of real username in kcm \
> module calls chfn to change real name in finger db, which will be reflected back in \
> KUser::FullName.
>
> Diffs
> -----
>
> kdepasswd/kcm/main.cpp 2471444
>
> Diff: http://git.reviewboard.kde.org/r/104965/diff/
>
>
> Testing
> -------
>
> Tested by QA crew of ROSA Desktop for ROSA Desktop 2012 LTS.
>
>
> Thanks,
>
> Aleksey Yermakov
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104965/">http://git.reviewboard.kde.org/r/104965/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104965/diff/1/?file=64609#file64609line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdepasswd/kcm/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCMUserAccount::~KCMUserAccount()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">147</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="n"><span class="hl">_mw</span></span><span \
class="o"><span class="hl">-></span></span><span class="n"><span \
class="hl">leR</span>ealname</span><span class="o"><span \
class="hl">-></span></span><span class="n"><span \
class="hl">setText</span></span><span class="p"><span class="hl">(</span></span> \
<span class="n">_kes</span><span class="o">-></span><span \
class="n">getSetting</span><span class="p">(</span> <span \
class="n">KEMailSettings</span><span class="o">::</span><span \
class="n">RealName</span> <span class="p">)<span \
class="hl">)</span>;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">147</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="hl"><span \
class="tb"> </span></span><span class="n"><span class="hl">QString</span></span><span \
class="hl"> </span><span class="n"><span class="hl">r</span>ealname</span><span \
class="hl"> </span><span class="o"><span class="hl">=</span></span> <span \
class="n">_kes</span><span class="o">-></span><span \
class="n">getSetting</span><span class="p">(</span> <span \
class="n">KEMailSettings</span><span class="o">::</span><span \
class="n">RealName</span> <span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nit: \
'realName' is better, as these are separate words.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/104965/diff/1/?file=64609#file64609line149" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdepasswd/kcm/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KCMUserAccount::~KCMUserAccount()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">149</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="k">if</span><span class="p">(</span><span \
class="n">realname</span><span class="p">.</span><span class="n">isEmpty</span><span \
class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">150</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">realname</span> <span \
class="o">=</span> <span class="n">_ku</span><span class="o">-></span><span \
class="n">property</span><span class="p">(</span><span class="n">KUser</span><span \
class="o">::</span><span class="n">FullName</span><span class="p">).</span><span \
class="n">toString</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
follow kdelibs' coding style here (4-space indentation, surrounding braces even \
for single-line statements):
if (foo) {
bar();
}</pre>
</div>
<br />
<p>- Raphael</p>
<br />
<p>On May 16th, 2012, 7:09 a.m., Aleksey Yermakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Aleksey Yermakov.</div>
<p style="color: grey;"><i>Updated May 16, 2012, 7:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added fallback for real username in kcm module.
Really helps in issues like this: http://bugs.rosalinux.ru/show_bug.cgi?id=179
Besides, such method seems natural, considering that change of real username in kcm \
module calls chfn to change real name in finger db, which will be reflected back in \
KUser::FullName. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by QA crew of ROSA Desktop for ROSA Desktop 2012 LTS.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdepasswd/kcm/main.cpp <span style="color: grey">(2471444)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104965/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic