--Boundary-01=_UOO6PMGygl+1M/O Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Em Monday 25 June 2012, Jaime escreveu: > 2012/6/23 Lamarque Vieira Souza > > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/105278/ > > > > On June 16th, 2012, 4:15 p.m., *Lamarque Vieira Souza* wrote: > > kdeui/actions/kaction.cpp > 1/?file=68027#file68027line408> (Diff > > > > revision 1) > > > > void KAction::setAuthAction(KAuth::Action *action) > > > > 408 > > > > //delete d->authAction; > > > > 408 > > > > delete d->authAction; > > > > Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that > > commented this line, but Dario did not give any reason why not delete > > the action. > > > > I think you should have asked Dario why he did this change in the first > > place, also you should not commit a patch without a "ship it" from > > another developer. > > > > Hi, I'm sorry. > > Saturday was, for me, one of those days where one should stay in bed. > Almost everything I did on Saturday was wrong :-(. Yesterday I was in > quarantine, I did not touch any computer at all. > I've been using reviewboard in the right way since I did a wrong file svn > commit long time ago, except: > * last saturday, sigh > * trivial commits of prefix ++ vs postfix ++ Well, just wait for the "ship it" next time. It can take a while to come but it will come. Dario, can you answer why did you comment line 408 of kdelibs/kdeui/actions/kaction.cpp? The one with "delete d->authAction;" in method KAction::setAuthAction(KAuth::Action *action). Does it solve any bug? > - Lamarque Vieira > > > On June 16th, 2012, 3:37 p.m., Jaime Torres Amate wrote: > > Review request for kdelibs. > > > > By Jaime Torres Amate. > > > > *Updated June 16, 2012, 3:37 p.m.* > > Description > > > > 1. Do not want to check m_startDate.isValid() twice and > > m_endDate.isValid() none. 2. why do not want to delete d->authAction if > > it is nulled after that. 3. Is really the code after the break unwanted > > code? > > 4. if ok is not initialized, sometimes while(ok) could do nothing. > > > > Testing > > > > 6 months or more with it locally. > > > > Diffs > > > > - kdecore/date/kcalendarera.cpp (0a21e37) > > - kdeui/actions/kaction.cpp (309cf82) > > - kio/kfile/kpropertiesdialog.cpp (feb0c9e) > > - sonnet/unicode/parseucd/parseucd.cpp (1c9b90e) > > > > View Diff -- Lamarque V. Souza KDE's Network Management maintainer http://planetkde.org/pt-br --Boundary-01=_UOO6PMGygl+1M/O Content-Type: text/html; charset="iso-8859-15" Content-Transfer-Encoding: 7bit

Em Monday 25 June 2012, Jaime escreveu:

> 2012/6/23 Lamarque Vieira Souza <lamarque@kde.org>

> > This is an automatically generated e-mail. To reply, visit:

> > http://git.reviewboard.kde.org/r/105278/

> >

> > On June 16th, 2012, 4:15 p.m., *Lamarque Vieira Souza* wrote:

> > kdeui/actions/kaction.cpp<http://git.reviewboard.kde.org/r/105278/diff/

> > 1/?file=68027#file68027line408> (Diff

> >

> > revision 1)

> >

> > void KAction::setAuthAction(KAuth::Action *action)

> >

> > 408

> >

> > //delete d->authAction;

> >

> > 408

> >

> > delete d->authAction;

> >

> > Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that

> > commented this line, but Dario did not give any reason why not delete

> > the action.

> >

> > I think you should have asked Dario why he did this change in the first

> > place, also you should not commit a patch without a "ship it" from

> > another developer.

> >

> > Hi, I'm sorry.

> Saturday was, for me, one of those days where one should stay in bed.

> Almost everything I did on Saturday was wrong :-(. Yesterday I was in

> quarantine, I did not touch any computer at all.

> I've been using reviewboard in the right way since I did a wrong file svn

> commit long time ago, except:

> * last saturday, sigh

> * trivial commits of prefix ++ vs postfix ++

Well, just wait for the "ship it" next time. It can take a while to come but it will come.

Dario, can you answer why did you comment line 408 of kdelibs/kdeui/actions/kaction.cpp? The one with "delete d->authAction;" in method KAction::setAuthAction(KAuth::Action *action). Does it solve any bug?

> - Lamarque Vieira

> > On June 16th, 2012, 3:37 p.m., Jaime Torres Amate wrote:

> > Review request for kdelibs.

> >

> > By Jaime Torres Amate.

> >

> > *Updated June 16, 2012, 3:37 p.m.*

> > Description

> >

> > 1. Do not want to check m_startDate.isValid() twice and

> > m_endDate.isValid() none. 2. why do not want to delete d->authAction if

> > it is nulled after that. 3. Is really the code after the break unwanted

> > code?

> > 4. if ok is not initialized, sometimes while(ok) could do nothing.

> >

> > Testing

> >

> > 6 months or more with it locally.

> >

> > Diffs

> >

> > - kdecore/date/kcalendarera.cpp (0a21e37)

> > - kdeui/actions/kaction.cpp (309cf82)

> > - kio/kfile/kpropertiesdialog.cpp (feb0c9e)

> > - sonnet/unicode/parseucd/parseucd.cpp (1c9b90e)

> >

> > View Diff <http://git.reviewboard.kde.org/r/105278/diff/>

Lamarque V. Souza

KDE's Network Management maintainer

http://planetkde.org/pt-br

--Boundary-01=_UOO6PMGygl+1M/O--