--===============0619070974010604794== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105337/ ----------------------------------------------------------- Review request for KDE Base Apps and David Faure. Description ------- The referenced bug suggested this option to cover the case where web sites = opened new windows (via JS) without user interface elements, if this is the= case there is no way to bring back the status bar which can show important= information. A patch was posted (http://lists.kde.org/?l=3Dkfm-devel&m=3D= 122885401907547&w=3D2) a long time ago, but it was rejected because Konquer= or's handling of the status bar is special (each view has its own status ba= r) and the patch took no account of that. Hopefully this updated patch does. The menu option only toggles the status= bar of the current view - I did think about making it do the status bars o= f all of the views simultaneously but was not sure whether this would be th= e right thing to do. Of course, for a single view in the window, the optio= n does what is expected anyway. There are GUI changes but no I18N strings (the KStandardAction is used). This addresses bug 111162. http://bugs.kde.org/show_bug.cgi?id=3D111162 Diffs ----- konqueror/src/konqmainwindow.h 1666370 = konqueror/src/konqmainwindow.cpp 0b49be5 = konqueror/src/konqueror.rc f788484 = Diff: http://git.reviewboard.kde.org/r/105337/diff/ Testing ------- Built Konqueror with these changes, tested with file management and web bro= wsing profiles with various window splits. Thanks, Jonathan Marten --===============0619070974010604794== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105337/

Review request for KDE Base Apps and David Faure.
By Jonathan Marten.

Descripti= on 

The referenced bug suggested this option to cover the case w=
here web sites opened new windows (via JS) without user interface elements,=
 if this is the case there is no way to bring back the status bar which can=
 show important information.  A patch was posted (http://lists.kde.org/?l=
=3Dkfm-devel&m=3D122885401907547&w=3D2) a long time ago, but it was=
 rejected because Konqueror's handling of the status bar is special (ea=
ch view has its own status bar) and the patch took no account of that.

Hopefully this updated patch does.  The menu option only toggles the status=
 bar of the current view - I did think about making it do the status bars o=
f all of the views simultaneously but was not sure whether this would be th=
e right thing to do.  Of course, for a single view in the window, the optio=
n does what is expected anyway.

There are GUI changes but no I18N strings (the KStandardAction is used).

Testing <= /h1> 
Built Konqueror with these changes, tested with file managem=
ent and web browsing profiles with various window splits.
Bugs: 111162

Diffs=

  • konqueror/src/konqmainwindow.h (1666370)
  • konqueror/src/konqmainwindow.cpp (0b49be5)=
  • konqueror/src/konqueror.rc (f788484)

View Diff
--===============0619070974010604794==--