On June 16th, 2012, 4:15 p.m., Lamarque Vieira Souza wrote:

kdeui/actions/kaction.cpp (Diff revision 1)
void KAction::setAuthAction(KAuth::Action *action)
408	//delete d->authAction;	408	delete d->authAction;

Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that commented this line, but Dario did not give any reason why not delete the action.

I think you should have asked Dario why he did this change in the first place, also you should not commit a patch without a "ship it" from another developer.

- Lamarque Vieira

On June 16th, 2012, 3:37 p.m., Jaime Torres Amate wrote:

1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid() none.
2. why do not want to delete d->authAction if it is nulled after that.
3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.

6 months or more with it locally.