This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105278/ |
On June 16th, 2012, 4:15 p.m., Lamarque Vieira Souza wrote:
kdeui/actions/kaction.cpp (Diff revision 1) void KAction::setAuthAction(KAuth::Action *action)408 //delete d->authAction;
408 delete d->authAction;Well, commit 3d789c9dcda0179aac40e2bcf58df06cccf84ed5 is the one that commented this line, but Dario did not give any reason why not delete the action.
I think you should have asked Dario why he did this change in the first place, also you should not commit a patch without a "ship it" from another developer.
- Lamarque Vieira
On June 16th, 2012, 3:37 p.m., Jaime Torres Amate wrote:
Review request for kdelibs.
By Jaime Torres Amate.
Updated June 16, 2012, 3:37 p.m. Description
Testing
Diffs
|