[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: kjs: Implement JSON.parse
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2012-06-18 22:25:22
Message-ID: 20120618222522.26722.58792 () vidsolbach ! de
[Download RAW message or body]
> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 37
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line37>
> >
> > What namespace do the symbols for this end up in?
> >
like all other generated luts, in the KJS namespace
> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/json_object.cpp, line 107
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line107>
> >
> > I think it's true, but needs one more proviso: the check on line 89.
Fixed with extra exception check
> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 193
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line193>
> >
> > I don't think this is needed anymore?
> > (Nor the similar one in arrays)
This is still needed, as object is NULL on if we get called from called from \
JSONArray-TokLBrace. Like the comment says.
> On June 10, 2012, 6:57 p.m., Maks Orlovich wrote:
> > kjs/jsonlexer.cpp, line 292
> > <http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line292>
> >
> > This looks like it will run out of stack space pretty quickly. I think it would \
> > be better to instead of firstArrayRun to have something more like what you have \
> > for objects. (Or just use propAdded in the same way)
I can't use propAdded because it has a different default-start value.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105056/#review14590
-----------------------------------------------------------
On May 28, 2012, 7:52 p.m., Bernd Buschinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105056/
> -----------------------------------------------------------
>
> (Updated May 28, 2012, 7:52 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> kjs: Implement JSON.parse
>
>
> Diffs
> -----
>
> kjs/CMakeLists.txt 1188064
> kjs/interpreter.cpp cf1acf1
> kjs/json_object.h PRE-CREATION
> kjs/json_object.cpp PRE-CREATION
> kjs/jsonlexer.h PRE-CREATION
> kjs/jsonlexer.cpp PRE-CREATION
> kjs/libkjs.map e9f679f
>
> Diff: http://git.reviewboard.kde.org/r/105056/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bernd Buschinski
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105056/">http://git.reviewboard.kde.org/r/105056/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2012, 6:57 p.m., <b>Maks \
Orlovich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line37" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/json_object.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">const ClassInfo JSONObjectImp::info = { "JSON", 0, &jsonTable, 0 \
};</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">37</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm">@begin jsonTable 1</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What namespace do the \
symbols for this end up in? </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">like all \
other generated luts, in the KJS namespace</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2012, 6:57 p.m., <b>Maks \
Orlovich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/3/?file=65731#file65731line107" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/json_object.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">const ClassInfo JSONObjectImp::info = { "JSON", 0, &jsonTable, 0 \
};</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// and we only have json data here</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it's true, \
but needs one more proviso: the check on line 89.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed with \
extra exception check</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2012, 6:57 p.m., <b>Maks \
Orlovich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line193" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/jsonlexer.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">JSValue* JSONParser::parse(ExecState* exec, ParserState state)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">193</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// this is needed for empty objects \
"[{}]"</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think this \
is needed anymore? (Nor the similar one in arrays)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
still needed, as object is NULL on if we get called from called from \
JSONArray-TokLBrace. Like the comment says.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 10th, 2012, 6:57 p.m., <b>Maks \
Orlovich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/105056/diff/3/?file=65733#file65733line292" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kjs/jsonlexer.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">JSValue* JSONParser::parse(ExecState* exec, ParserState state)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">292</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">addArrayItem</span><span class="p">(</span><span class="n">exec</span><span \
class="p">,</span> <span class="o">&</span><span \
class="n">arrayObjectStack</span><span class="p">,</span> <span \
class="n">parse</span><span class="p">(</span><span class="n">exec</span><span \
class="p">,</span> <span class="n">JSONValue</span><span class="p">),</span> <span \
class="n">object</span><span class="p">))</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks like it will \
run out of stack space pretty quickly. I think it would be better to instead of \
firstArrayRun to have something more like what you have for objects. (Or just use \
propAdded in the same way) </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't \
use propAdded because it has a different default-start value.</pre> <br />
<p>- Bernd</p>
<br />
<p>On May 28th, 2012, 7:52 p.m., Bernd Buschinski wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>
<p style="color: grey;"><i>Updated May 28, 2012, 7:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Implement JSON.parse</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/CMakeLists.txt <span style="color: grey">(1188064)</span></li>
<li>kjs/interpreter.cpp <span style="color: grey">(cf1acf1)</span></li>
<li>kjs/json_object.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/json_object.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/jsonlexer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/jsonlexer.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kjs/libkjs.map <span style="color: grey">(e9f679f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105056/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic