[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Default file manager and folder associations
From:       Mark <markg85 () gmail ! com>
Date:       2012-06-18 13:15:56
Message-ID: CAPd6JnH1nR-P9MJLs5_XYt8_r37fMk91Jy1Q6t-okodb0EOG_w () mail ! gmail ! com
[Download RAW message or body]

On Sun, Jun 17, 2012 at 10:45 PM, Thomas L=FCbking
<thomas.luebking@gmail.com> wrote:
> Am 17.06.2012, 22:18 Uhr, schrieb Jacopo De Simoi <wilderkde@gmail.com>:
>
>
>> so in the end I agree with you that the crucial issue is the misleading
>> caption of the checkbox in the =93open with=85=94 dialog.
>> Who is the right person to discuss with?
>
>
> it's not like i didn't have to look it up myself (lxr.kde.org)
> http://api.kde.org/4.8-api/kdelibs-apidocs/kio/html/classKOpenWithDialog.=
html
>
> Pino seems to have touched it last, more i do not know either - just writ=
e a
> patch ;-)
>
> Cheers,
> Thomas

So, i did some deeper digging into this. Quite interesting results to
say the least :)
In the file: kio/kfile/kopenwithdialog.cpp line 779 you can find:
  apps.prepend(serviceId); // make it the preferred app

Yes, even with that comment behind it.
A git blame turns out that David is the one to "blame" for that one:

5bf58ae2 kio/kfile/kopenwithdialog.cpp (David Faure         2008-02-29
21:12:14 +0000 779)     apps.prepend(serviceId); // make it the
preferred app

Perhaps David can shed some light on this little issue?


I'm guessing the following would be the best solution:
- Add a chechbox that becomes tickable when you tick "Remember ....".
The added checkbox should say something like: "Make default"
- By default (so when the "Make default" is not checked) it should
append the item to the list, not prepend.

Just my 5 cents :)
[prev in list] [next in list] [prev in thread] [next in thread]