[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: fix for some typos
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-06-16 15:37:40
Message-ID: 20120616153740.32584.10534 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105278/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
1. Do not want to check m_startDate.isValid() twice and m_endDate.isValid()=
none.
2. why do not want to delete d->authAction if it is nulled after that.
3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.
Diffs
-----
kdecore/date/kcalendarera.cpp 0a21e37 =
kdeui/actions/kaction.cpp 309cf82 =
kio/kfile/kpropertiesdialog.cpp feb0c9e =
sonnet/unicode/parseucd/parseucd.cpp 1c9b90e =
Diff: http://git.reviewboard.kde.org/r/105278/diff/
Testing
-------
6 months or more with it locally.
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105278/">http://git.reviewboard.kde.org/r/105278/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Do not want to check m_startDate.isValid() twice and \
m_endDate.isValid() none. 2. why do not want to delete d->authAction if it is \
nulled after that. 3. Is really the code after the break unwanted code?
4. if ok is not initialized, sometimes while(ok) could do nothing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">6 months or more with it locally.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/date/kcalendarera.cpp <span style="color: grey">(0a21e37)</span></li>
<li>kdeui/actions/kaction.cpp <span style="color: grey">(309cf82)</span></li>
<li>kio/kfile/kpropertiesdialog.cpp <span style="color: grey">(feb0c9e)</span></li>
<li>sonnet/unicode/parseucd/parseucd.cpp <span style="color: \
grey">(1c9b90e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105278/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic