[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication
From: "Martin Koller" <kollix () aon ! at>
Date: 2012-06-16 11:36:10
Message-ID: 20120616113610.8684.90383 () vidsolbach ! de
[Download RAW message or body]
> On June 15, 2012, 11:38 p.m., Steven Sroka wrote:
> > Martin, what's the status of this patch? I think a bunch of bug reports=
on bko are waiting to get closed ;)
There was a mail thread on core-devel for this and Thiago Macieira said it'=
s the wrong approach.
I'll remove the patch ...
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103699/#review14773
-----------------------------------------------------------
On Jan. 15, 2012, 5:28 p.m., Martin Koller wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103699/
> -----------------------------------------------------------
> =
> (Updated Jan. 15, 2012, 5:28 p.m.)
> =
> =
> Review request for kdelibs.
> =
> =
> Description
> -------
> =
> All KUniqueApplications issue the warning
> QDBusConnection: session D-Bus connection created before QCoreApplication=
. Application may misbehave.
> when runngin with Qt-4.8.0 (qWarning in QDBusDefaultConnection ctor)
> =
> The patch avoids this by temporarily creating a QCoreApplication instance
> =
> =
> Diffs
> -----
> =
> kdeui/kernel/kuniqueapplication.cpp 777fc35 =
> =
> Diff: http://git.reviewboard.kde.org/r/103699/diff/
> =
> =
> Testing
> -------
> =
> running kdepasswd
> =
> =
> Thanks,
> =
> Martin Koller
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103699/">http://git.reviewboard.kde.org/r/103699/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 15th, 2012, 11:38 p.m., <b>Steven \
Sroka</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Martin, what's the status of this patch? I think a bunch of bug \
reports on bko are waiting to get closed ;)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There was a mail thread \
on core-devel for this and Thiago Macieira said it's the wrong approach. I'll \
remove the patch ...</pre> <br />
<p>- Martin</p>
<br />
<p>On January 15th, 2012, 5:28 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2012, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All KUniqueApplications issue the warning
QDBusConnection: session D-Bus connection created before QCoreApplication. \
Application may misbehave. when runngin with Qt-4.8.0 (qWarning in \
QDBusDefaultConnection ctor)
The patch avoids this by temporarily creating a QCoreApplication instance</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">running kdepasswd</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kuniqueapplication.cpp <span style="color: \
grey">(777fc35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic