[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: UDisks mount vfat filesystems with flush option.
From:       Konstantinos Smanis <konstantinos.smanis () gmail ! com>
Date:       2012-06-13 21:32:36
Message-ID: CANJf_cAKSRnqvNsnKLcz9Nvii_8yJRwnhjCiPi=6Meq5rvVH7Q () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jun 12, 2012 at 11:33 AM, Maarten De Meyer
<de.meyer.maarten@gmail.com> wrote:
>
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105224/
>
> Review request for kdelibs, Solid and Luk=C3=A1=C5=A1 Tinkl.
> By Maarten De Meyer.
>
> Description
>
> This patch mounts vfat filesystems (mostly usb devices) with the flush
> option when using the UDisks backend. The hal backend already did this.
> The flush option makes sure changes are written to the device immediately=
.
>
> Please let me know it this should be implemented in an other (optional)
> way or if this should be in the UDev rules directly.
>
> ps. I do not have commit rights.
>
> Testing
>
> Compiled without error, mounted multiple devices without problems.
>
> Bugs: 273792
>
> Diffs
>
> solid/solid/backends/udisks/udisksstorageaccess.cpp (7d72a88)
>
> View Diff

I tested the patch against 4.8.3, works as expected.

However, I too think that this option should be implemented somewhere
else in the stack (udisks/udev: whatever is most fit). Although a sane
default, you should be able to configure it more easily.

--
Konstantinos Smanis
[prev in list] [next in list] [prev in thread] [next in thread]