From kde-core-devel  Wed Jun 13 00:42:28 2012
From: Michael Pyne <mpyne () kde ! org>
Date: Wed, 13 Jun 2012 00:42:28 +0000
To: kde-core-devel
Subject: Question regarding compatibility for kdecore and KDE4_ENABLE_FINAL
Message-Id: <2064239.slJBn3zT8H () midna>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=133954838120688
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--nextPart8428227.WBf4VSVbKR"


--nextPart8428227.WBf4VSVbKR
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"

Hi all,

Bug 301419 has been reported against kdelibs due to a build failure when 
KDE4_ENABLE_FINAL is used, introduced by some commits of mine to perform even 
more sanity checking in the KSharedDataCache.

These commits use exceptions (as are already used in khtml) since they are 
actually "the right tool" in the context of where they are used, and because 
refactoring everything to use error codes everywhere (ECE) would have risked 
introducing more bugs.

In order to minimize the changes to kdecore I only added the CMake magic to 
enable exceptions for only kshareddatacache.cpp. This doesn't work when 
KDE4_ENABLE_FINAL is used, as the project-wide CXXFLAGS are used in that case.

The Mageia devs have a proposed patch [1] to enable exceptions for all of 
kdecore, which fixes the issue. Is it acceptable for me to go this route? The 
only real alternative this late in the game is to back out the sanity checks 
to the 4.8.3 status or to explicitly say that KDE4_ENABLE_FINAL will not work 
for this tarball although it worked for 4.8.3, both of which I consider less 
desirable. But I don't want to make the change if there are good reasons to 
avoid it.

Longer term (for frameworks) KSharedDataCache could be split into its own tier 
if necessary (it only really depends on Qt and KStandardDirs, which is now 
also in Qt...).

Regards,
 - Michael Pyne

[1] 
http://svnweb.mageia.org/packages/cauldron/kdelibs4/current/SOURCES/kdelibs-4.8.4-
correct-use-fexception-switch.patch?revision=260068&view=markup
--nextPart8428227.WBf4VSVbKR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAABCAAGBQJP1+H0AAoJEAuvDJx7aunyXlIP/Rf2PrMOpb411KqPWoBnFfEx
dNlJa7XNk77Z1ZZCd1N2yu8ugF/O41Z3fH0WxYaDsyRLtqM/IP1HTcxYjITxwyx8
YZmpPmt7xah7rJuFi0SsEF2KgsyAKVTTEoMuiT65augxy3NdFvwm81zbubvw0S1v
wGAUvsvsXZ3HxCMnEdek5DnaWPucC1x5+rK9ZnZ4lQD9d3JnMHO/h/rtW7Sq8HlK
gGuUkxDnm9yjnwb8O1Dlq+6s8W9OGZlTjs5egMXa7e0b+ICuJXAuTyCvgYrInDr2
v5y1kfaDhQKbCHuxBmV3mEHGdjSar2A0xkebUkN2zVmUtLdMxHqq3ZrnjYGbsYZT
fsn5a/ksmOE/XlRfYhCXqzCh2eSqtQ9DCzE7opIaxS2kIR2fJB8xV9kl4JxWYUfB
zz8RZDMMpfot22Y1OGLKKTO7epkAo3s4gQ04xQDGcdXAQ2QvrthhVZCowAvTJG3/
tHzyfRpfmL8x0iMEJjShzOeKNDCp3mO8isO0UcUc9bS8aT23pxbO+PNwfxHwhGX0
dzqQ0RaW84ZSX1YjyTa4A/EAmv6jMmanhO9q1kez82T5kCAlEtbWYn3Ov/0TdOU+
Huq/NCVqWsLaqI4Dk2xOu5DlHp2kTYJUbDDfoyR0UwCvx2sVGBjHJRcsvUHYsh5u
ExW3Q/635F9kwUttr1en
=fRFS
-----END PGP SIGNATURE-----

--nextPart8428227.WBf4VSVbKR--