'Re: Review Request: UDisks mount vfat filesystems with flush option.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: UDisks mount vfat filesystems with flush option.
From:       "Commit Hook" <null () kde ! org>
Date:       2012-06-12 10:28:53
Message-ID: 20120612102853.17192.20712 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105224/#review14649
-----------------------------------------------------------


This review has been submitted with commit 6f8a052881ac699ff2cc4917b32f4620c599a24f \
by Lukas Tinkl to branch KDE/4.8.

- Commit Hook


On June 12, 2012, 8:33 a.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105224/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 8:33 a.m.)
> 
> 
> Review request for kdelibs, Solid and Lukáš Tinkl.
> 
> 
> Description
> -------
> 
> This patch mounts vfat filesystems (mostly usb devices) with the flush option when \
> using the UDisks backend. The hal backend already did this. The flush option makes \
> sure changes are written to the device immediately. 
> Please let me know it this should be implemented in an other (optional) way or if \
> this should be in the UDev rules directly. 
> ps. I do not have commit rights.
> 
> 
> This addresses bug 273792.
> http://bugs.kde.org/show_bug.cgi?id=273792
> 
> 
> Diffs
> -----
> 
> solid/solid/backends/udisks/udisksstorageaccess.cpp 7d72a88 
> 
> Diff: http://git.reviewboard.kde.org/r/105224/diff/
> 
> 
> Testing
> -------
> 
> Compiled without error, mounted multiple devices without problems.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105224/">http://git.reviewboard.kde.org/r/105224/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 6f8a052881ac699ff2cc4917b32f4620c599a24f by Lukas Tinkl to \
branch KDE/4.8.</pre>  <br />







<p>- Commit</p>


<br />
<p>On June 12th, 2012, 8:33 a.m., Maarten De Meyer wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Solid and Lukáš Tinkl.</div>
<div>By Maarten De Meyer.</div>


<p style="color: grey;"><i>Updated June 12, 2012, 8:33 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch mounts vfat filesystems (mostly usb devices) with the flush \
option when using the UDisks backend. The hal backend already did this. The flush \
option makes sure changes are written to the device immediately.

Please let me know it this should be implemented in an other (optional) way or if \
this should be in the UDev rules directly.

ps. I do not have commit rights.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled without error, mounted multiple devices without problems.</pre> \
</td>  </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=273792">273792</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>solid/solid/backends/udisks/udisksstorageaccess.cpp <span style="color: \
grey">(7d72a88)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105224/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic