[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: kdelibs and Qt version dependency
From: Anne-Marie Mahfouf <annemarie.mahfouf () free ! fr>
Date: 2012-06-06 6:11:22
Message-ID: 4FE82687.1 () free ! fr
[Download RAW message or body]
On 06/06/2012 03:19 AM, Dawit A wrote:
> It is a simple matter to put a #ifdef around the code that does not
> compile with Qt 4.7. I wish this issue was raised when the code was up
> for review for more than a month or the Qt documentation mentioned
> something about those functions only being available in Qt 4.8.
>
> Anyhow, I have attached a patch that should make it compile on Qt
> 4.7.x. If someone is willing to test it against Qt 4.7 and let me know
> if it compiles and works fine for them, I can commit it. It will
> however mean that bug# 275524 will not be fixed for those using Qt 4.7.
>
> On Tue, Jun 5, 2012 at 3:16 PM, Albert Astals Cid <aacid@kde.org
> <mailto:aacid@kde.org>> wrote:
>
> On May 19, Dawit Alemayehu commited a change that uses
> QSslConfiguration::testSslOption that is only available in Qt 4.8
>
> This means that both kdelibs 4.8.4 and kdelibs 4.9 now depend in
> Qt 4.8
> instead Qt 4.7
>
> I want to ask the kdelibs maintainers:
>
> a) Do you think it makes sense to change our Qt required version from
> Qt 4.7 in kdelibs 4.8.3
> to
> Qt 4.8 in kdelibs 4.8.4
> ?
>
> b) Do you think kdelibs 4.9 should depend in Qt 4.8 or not?
>
> Cheers,
> Albert
>
>
I tried the patch, you forgot some stuff. I am working on the 4.8.80
kdelibs tarball if that matters.
I added
#if QT_VERSION >= 0x040800
if (sslConfig.testSslOption(QSsl::SslOptionDisableCompression)
&& !shouldSslCompressBeDisabled) {
setMetaData(QLatin1String("{internal~currenthost}LastUsedSslDisableCompressionFlag"),
QString::number(true));
}
#endif
and
#if QT_VERSION >= 0x040800
kDebug(7027) << "Trying SSL handshake with protocol:" << version
<< ", SSL compression ON:" <<
sslConfig.testSslOption(QSsl::SslOptionDisableCompression);
#endif
and it built.
Anne-Marie
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 06/06/2012 03:19 AM, Dawit A wrote:
<blockquote
cite="mid:CALa28R5ZUAUo2=+nypnLF419q92v59u8T1eY_vE+aXNTDf0VaA@mail.gmail.com"
type="cite">
<div>It is a simple matter to put a #ifdef around the code that
does not compile with Qt 4.7. I wish this issue was raised when
the code was up for review for more than a month or the Qt
documentation mentioned something about those functions only
being available in Qt 4.8. </div>
<div><br>
</div>
<div>Anyhow, I have attached a patch that should make it compile
on Qt 4.7.x. If someone is willing to test it against Qt 4.7 and
let me know if it compiles and works fine for them, I can commit
it. It will however mean that bug# 275524 will not be fixed for
those using Qt 4.7.</div>
<div><br>
<div class="gmail_quote">On Tue, Jun 5, 2012 at 3:16 PM, Albert
Astals Cid <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
On May 19, Dawit Alemayehu commited a change that uses<br>
QSslConfiguration::testSslOption that is only available in
Qt 4.8<br>
<br>
This means that both kdelibs 4.8.4 and kdelibs 4.9 now
depend in Qt 4.8<br>
instead Qt 4.7<br>
<br>
I want to ask the kdelibs maintainers:<br>
<br>
a) Do you think it makes sense to change our Qt required
version from<br>
Qt 4.7 in kdelibs 4.8.3<br>
to<br>
Qt 4.8 in kdelibs 4.8.4<br>
?<br>
<br>
b) Do you think kdelibs 4.9 should depend in Qt 4.8 or not?<br>
<br>
Cheers,<br>
Albert<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
I tried the patch, you forgot some stuff. I am working on the 4.8.80
kdelibs tarball if that matters.<br>
I added<br>
<br>
#if QT_VERSION >= 0x040800<br>
if
(sslConfig.testSslOption(QSsl::SslOptionDisableCompression)
&& !shouldSslCompressBeDisabled) {<br>
setMetaData(QLatin1String("{internal~currenthost}LastUsedSslDisableCompressionFlag"),<br>
QString::number(true));<br>
}<br>
#endif<br>
<br>
and<br>
<br>
#if QT_VERSION >= 0x040800<br>
kDebug(7027) << "Trying SSL handshake with protocol:"
<< version<br>
<< ", SSL compression ON:" <<
sslConfig.testSslOption(QSsl::SslOptionDisableCompression);<br>
#endif<br>
<br>
and it built.<br>
<br>
Anne-Marie<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic