[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request: type of NET::WindowTypeMask
From: "Jaime Torres Amate" <jtamate () gmail ! com>
Date: 2012-06-04 16:41:41
Message-ID: 20120604164141.6883.40265 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105142/
-----------------------------------------------------------
Review request for kdelibs.
Description
-------
According to clang++, the implicit type conversion for NET::WindowTypeMask is \
unsigned long, not int.
implicit conversion from 'NET::WindowTypeMask' to 'int' changes value from \
18446744073709551615 to -1 [-Wconstant-conversion] NET::WindowType type = \
info.windowType(NET::AllTypesMask); ~~~~ ^~~~~~~~~~~~~~~~~
probably because in NET:WindowTypeMask, AllTypesMask is declared as:
AllTypesMask = 0LU-1 ///< All window types.
The other possible solution could be to declare
AllTypesMask = -1 ///< All window types.
to make NET::WindowType to be an int.
Diffs
-----
tier1/kwindowsystem/src/kwindowinfo.h b899d22
tier1/kwindowsystem/src/kwindowinfo_mac.cpp 9756254
tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9
tier1/kwindowsystem/src/kwindowinfo_x11.cpp f382e9c
Diff: http://git.reviewboard.kde.org/r/105142/diff/
Testing
-------
Thanks,
Jaime Torres Amate
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105142/">http://git.reviewboard.kde.org/r/105142/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres Amate.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">According to clang++, the implicit type conversion for \
NET::WindowTypeMask is unsigned long, not int.
implicit conversion from 'NET::WindowTypeMask' to 'int' changes value \
from 18446744073709551615 to -1 [-Wconstant-conversion] NET::WindowType type = \
info.windowType(NET::AllTypesMask); ~~~~ ^~~~~~~~~~~~~~~~~
probably because in NET:WindowTypeMask, AllTypesMask is declared as:
AllTypesMask = 0LU-1 ///< All window types.
The other possible solution could be to declare
AllTypesMask = -1 ///< All window types.
to make NET::WindowType to be an int.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kwindowsystem/src/kwindowinfo.h <span style="color: \
grey">(b899d22)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_mac.cpp <span style="color: \
grey">(9756254)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_win.cpp <span style="color: \
grey">(d392fe9)</span></li>
<li>tier1/kwindowsystem/src/kwindowinfo_x11.cpp <span style="color: \
grey">(f382e9c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105142/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic