[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request: Apper on kdereview
From:       Burkhard =?utf-8?q?L=C3=BCck?= <lueck () hube-lueck ! de>
Date:       2012-05-24 16:44:12
Message-ID: 201205241844.12605.lueck () hube-lueck ! de
[Download RAW message or body]

Am Donnerstag, 24. Mai 2012, 17:07:20 schrieb Matthias Klumpp:
> Hi!
> @Albert: Isn't this the line?
> https://projects.kde.org/projects/kdereview/apper/repository/revisions/mast
> er/entry/AppSetup/main.cpp#L44 (please tell me if there's something wrong
> ^^)
> 
Afaik the insertCatalog() call is done too early and won't work.

KAboutData Class Reference says about the second parameter of the constructor:
catalogName	
The translation catalog name; if null or empty, the appName will be used. You 
may want the catalog name to differ from program name, for example, when you 
want to group translations of several smaller utilities under the same 
catalog.

So I'd use: 
KAboutData aboutData("appsetup-kde", "apper", ...

> @Burkhard: The files have been moved - but I think I copied the
> location scheme from another project, so this issue might affect other
> projects too. (but I'm not completely sure... everything I've checked
> so far is sane)
> 
Yuri added apper/doc to scripty's workflow, man pages will be processed 
tomorrow morning.

Thanks.

-- 
Burkhard Lück
[prev in list] [next in list] [prev in thread] [next in thread]