[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Add warning for searching the complete file system
From: "Mark Gaiser" <markg85 () gmail ! com>
Date: 2012-05-03 19:35:00
Message-ID: 20120503193500.28908.82310 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104826/#review13382
-----------------------------------------------------------
Let me first say that i have absolutely nothing to say about this. I do hav=
e an opinion about this though.
I would not like this. If i'm searching i just want to search and certainly=
don't get a dialog just to confirm my search.
Others might think differently though... Perhaps as an option but disabled =
by default.
- Mark Gaiser
On May 2, 2012, 7:50 p.m., Andre Heinecke wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104826/
> -----------------------------------------------------------
> =
> (Updated May 2, 2012, 7:50 p.m.)
> =
> =
> Review request for KDE Base Apps.
> =
> =
> Description
> -------
> =
> In my company it regularly happens that some "non technical" person, e.g.=
a secretary or a marketing guy tries to find a file he or she has no idea =
where it is placed.
> When they use kfind to search the complete file system without using loca=
te this pretty much means a DOS attack on our company network with loads of=
NFS shares etc.
> =
> Searching the complete filesystem is nearly always wrong but as users are=
used to it from "Search my Computer" or other indexed search options they =
might not realize it.
> =
> This Patch adds a confirmation dialog if you want to search / or file:///=
recursively without using locate warning you that this might take a very l=
ong time and is a resource intensive operation
> =
> =
> Diffs
> -----
> =
> kfind/kfinddlg.cpp 12b3b7e =
> kfind/kquery.h 39609f3 =
> =
> Diff: http://git.reviewboard.kde.org/r/104826/diff/
> =
> =
> Testing
> -------
> =
> Compiled, tested with regular paths, as well as / and file:///
> =
> =
> Thanks,
> =
> Andre Heinecke
> =
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104826/">http://git.reviewboard.kde.org/r/104826/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Let me first say that i \
have absolutely nothing to say about this. I do have an opinion about this though. I \
would not like this. If i'm searching i just want to search and certainly \
don't get a dialog just to confirm my search.
Others might think differently though... Perhaps as an option but disabled by \
default.</pre> <br />
<p>- Mark</p>
<br />
<p>On May 2nd, 2012, 7:50 p.m., Andre Heinecke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Andre Heinecke.</div>
<p style="color: grey;"><i>Updated May 2, 2012, 7:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In my company it regularly happens that some "non technical" \
person, e.g. a secretary or a marketing guy tries to find a file he or she has no \
idea where it is placed. When they use kfind to search the complete file system \
without using locate this pretty much means a DOS attack on our company network with \
loads of NFS shares etc.
Searching the complete filesystem is nearly always wrong but as users are used to it \
from "Search my Computer" or other indexed search options they might not \
realize it.
This Patch adds a confirmation dialog if you want to search / or file:/// recursively \
without using locate warning you that this might take a very long time and is a \
resource intensive operation</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, tested with regular paths, as well as / and file:///</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfind/kfinddlg.cpp <span style="color: grey">(12b3b7e)</span></li>
<li>kfind/kquery.h <span style="color: grey">(39609f3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104826/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic