--===============2226529401696876222== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104826/ ----------------------------------------------------------- Review request for KDE Base Apps. Description ------- In my company it regularly happens that some "non technical" person, e.g. a= secretary or a marketing guy tries to find a file he or she has no idea wh= ere it is placed. When they use kfind to search the complete file system without using locate= this pretty much means a DOS attack on our company network with loads of N= FS shares etc. Searching the complete filesystem is nearly always wrong but as users are u= sed to it from "Search my Computer" or other indexed search options they mi= ght not realize it. This Patch adds a confirmation dialog if you want to search / or file:/// r= ecursively without using locate warning you that this might take a very lon= g time and is a resource intensive operation Diffs ----- kfind/kfinddlg.cpp 12b3b7e = kfind/kquery.h 39609f3 = Diff: http://git.reviewboard.kde.org/r/104826/diff/ Testing ------- Compiled, tested with regular paths, as well as / and file:/// Thanks, Andre Heinecke --===============2226529401696876222== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104826/

Review request for KDE Base Apps.

By Andre Heinecke.

Descripti= on

In my company it regularly happens that some "non techn=
ical" person, e.g. a secretary or a marketing guy tries to find a file=
 he or she has no idea where it is placed.
When they use kfind to search the complete file system without using locate=
 this pretty much means a DOS attack on our company network with loads of N=
FS shares etc.

Searching the complete filesystem is nearly always wrong but as users are u=
sed to it from "Search my Computer" or other indexed search optio=
ns they might not realize it.

This Patch adds a confirmation dialog if you want to search / or file:/// r=
ecursively without using locate warning you that this might take a very lon=
g time and is a resource intensive operation

Testing <= /h1>

Compiled, tested with regular paths, as well as / and file:/=
//

Diffs=

kfind/kfinddlg.cpp (12b3b7e)
kfind/kquery.h (39609f3)

--===============2226529401696876222==--